gh-143897: Remove the isxidstart() and isxidcontinue() methods of unicodedata.ucd_3_2_0#143898
+39 −57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…of unicodedata.ucd_3_2_0 They are now only exposed as the unicodedata function.
vstinner approved these changes Jan 16, 2026
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM. I didn't notice that isxidstart() and isxidcontinue() were added to unicodedata.ucd_3_2_0. I don't think that we need them, so they can be removed.
MemberAuthor
serhiy-storchaka commented Jan 16, 2026
At the time they were added, there was no precedence and mechanism to add only function to |
Member
StanFromIreland commented Jan 16, 2026
Yes, that is why I added the fast-path instead. |
StanFromIreland approved these changes Jan 16, 2026
Misc/NEWS.d/next/Library/2026-01-16-10-53-17.gh-issue-143897.hWJBHN.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
…WJBHN.rst Co-authored-by: Stan Ulbrych <[email protected]>
serhiy-storchaka merged commit bb2b9ba into python:main 47 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are now only exposed as the unicodedata function.