Skip to content

gh-143919: Reject control characters in http cookies#143920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sethmlarson merged 5 commits into from
Jan 20, 2026
Merged

gh-143919: Reject control characters in http cookies #143920

sethmlarson merged 5 commits into from
Jan 20, 2026
+80 −9

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarsonsethmlarson commented Jan 16, 2026•
edited by bedevere-app bot
Loading

@sethmlarsonsethmlarson added type-security A security issue needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 16, 2026
@bedevere-appbedevere-appbot mentioned this pull request Jan 16, 2026
Open
johnslavik
johnslavik reviewed Jan 16, 2026
View reviewed changes
@sethmlarson@johnslavik
Apply suggestions from code review
03f222d
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
sobolevn
sobolevn reviewed Jan 16, 2026
View reviewed changes
@sethmlarson@sobolevn
Apply suggestions from code review
6b999b5
Co-authored-by: sobolevn <mail@sobolevn.me>
@Yhg1sYhg1s changed the title gh-143919: Reject control characters http cookiesgh-143919: Reject control characters in http cookiesJan 19, 2026
@sethmlarsonsethmlarson enabled auto-merge (squash) January 20, 2026 20:58
@sethmlarsonsethmlarson merged commit 95746b3 into python:mainJan 20, 2026
47 checks passed
@miss-islington-app
Copy link

miss-islington-appbot commented Jan 20, 2026

Thanks @sethmlarson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12, 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-appbot commented Jan 20, 2026

Sorry, @sethmlarson, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 95746b3a13a985787ef53b977129041971ed7f70 3.10

@sethmlarsonsethmlarson deleted the reject-control-characters-http-cookies branch January 20, 2026 21:35
@sethmlarsonsethmlarson removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jan 20, 2026
@sethmlarsonsethmlarson removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 20, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

@johnslavikjohnslavikjohnslavik left review comments

@Yhg1sYhg1sYhg1s approved these changes

@gpsheadgpsheadAwaiting requested review from gpshead

Assignees

@sethmlarsonsethmlarson

Labels

type-securityA security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sethmlarson@Yhg1s@sobolevn@johnslavik