Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Jan 16, 2026

Continuation of #136729.

Original description:


Notes

Please see #136728. Changes to build.yml are directly adapted from @hugovk's proof-of-concept here.

Testing

  • this PR's CI
  • PR CI on my fork.

run: |
echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV"
- name: Configure CPython
run: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>- makes EOL escaping redundant while allowing for nice line separation of long/logically self-contained components:

Suggested change
run: |
env:
CONFIGURE_TRAILING_ARGS: >-
${{
matrix.ssl != 'openssl'
&& '--with-builtin-hashlib-hashes=blake2 --with-ssl-default-suites=openssl'
|| ''
}}
run: >-

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer \ becauseI find them easier to read. I find the >- harder to read honestly.

Comment on lines +312 to +317
CMD=(./configure CFLAGS="-fdiagnostics-format=json" --config-cache --enable-slower-safety --with-pydebug --with-openssl="$SSL_DIR")
if [ "${{matrix.ssl }}" = "openssl" ]; then
"${CMD[@]}"
else
"${CMD[@]}" --with-builtin-hashlib-hashes=blake2 --with-ssl-default-suites=openssl
fi
Copy link
Member

@webknjazwebknjazJan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CMD=(./configure CFLAGS="-fdiagnostics-format=json" --config-cache --enable-slower-safety --with-pydebug --with-openssl="$SSL_DIR")
if [ "${{matrix.ssl }}" = "openssl" ]; then
"${CMD[@]}"
else
"${CMD[@]}"--with-builtin-hashlib-hashes=blake2 --with-ssl-default-suites=openssl
fi
./configure
CFLAGS="-fdiagnostics-format=json"
--config-cache
--enable-slower-safety
--with-pydebug
--with-openssl="$SSL_DIR"
${CONFIGURE_TRAILING_ARGS}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the if/else approach. I do not like the notion of 'trailing' args.

@webknjazwebknjaz moved this to 🧐 @webknjaz's review queue 📋 in 📅 Procrastinating in publicJan 16, 2026

@property
@abstractmethod
deflibrary(self=None):
Copy link
Member

@picnixzpicnixzJan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as I said previously, we should just have annotated properties. It will complain at runtime if we are missing one.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you make GH suggestions here, or a PR to my branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry I am on mobile only (I am travelling) so I cannot do it easily :(

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No rush, it can wait!

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infraCI, GitHub Actions, buildbots, Dependabot, etc.skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@hugovk@webknjaz@picnixz@WillChilds-Klein