Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-102809: No longer mention Misc/gdbinit in the code#143980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
johnslavik commented Jan 18, 2026 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
Misc/gdbinit in PyObject_Dump code docMisc/gdbinit in the code
StanFromIreland left a comment • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or fix it like this one was done?
cpython/Doc/howto/gdb_helpers.rst
Line 40 in 63cc125
| - GDB 7 or later. (For earlier versions of GDB, see ``Misc/gdbinit`` in the |
johnslavik commented Jan 18, 2026 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
I'm not sure. This comment remains on 3.10, 3.11 and 3.12 branches, would including We could direct the reader to |
StanFromIreland commented Jan 18, 2026
Oh I only have the one line shown, I was referring to: "see |
johnslavik commented Jan 18, 2026 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Thanks. Personally, I don't find it necessary, because the 3.11 and earlier branches still will include the mention of |
StanFromIreland commented Jan 18, 2026
Why do those branches matter? The comment is for people on the branches where the file doesn't exist, no? |
johnslavik commented Jan 18, 2026
I was thinking that mentioning If they needed to debug 3.11, they would check it out and the comment would be there. |
johnslavik commented Jan 18, 2026
Do you have an example of when this is useful for someone debugging in the 3.13-3.15 branches only? |
ZeroIntensity commented Jan 18, 2026
Yeah, I agree with Bartosz here. The mention in the docs was added after |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Misc/gdbinit in the codeMisc/gdbinit in the codef84ea11 into python:mainUh oh!
There was an error while loading. Please reload this page.
Thanks @johnslavik for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…GH-143980) Fix misleading comment on `PyObject_Dump`. (cherry picked from commit f84ea11) Co-authored-by: Bartosz Sławecki <[email protected]>
…GH-143980) Fix misleading comment on `PyObject_Dump`. (cherry picked from commit f84ea11) Co-authored-by: Bartosz Sławecki <[email protected]>
GH-144044 is a backport of this pull request to the 3.14 branch. |
GH-144045 is a backport of this pull request to the 3.13 branch. |
vstinner commented Jan 19, 2026
Merged, thanks for this cleanup. |
johnslavik commented Jan 19, 2026
@vstinner, thanks for the review and for linking the issue! |
Misc/gdbinitwas removed in GH-102854 (3.12.0a7).Misc/gdbinit? #102809