GH-139109: Partial reworking of JIT data structures#144105
Open
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Halve size of buffers by reusing combined trace + optimizer buffers for TOS caching * Add simple buffer struct for more maintainable handling of buffers * Decouple JIT structs from thread state struct * Ensure terminator is added to trace, when optimizer gives up
markshannon requested review from Fidget-Spinner, ZeroIntensity, ericsnowcurrently, savannahostrowski and tomasr8 as code owners
Fidget-Spinner approved these changes Jan 21, 2026
Member
Fidget-Spinner left a comment
Fidget-Spinner left a comment There was a problem hiding this comment.
Just 2 nits, please address them and merge.
| staticinlineint | ||
| uop_buffer_length(_PyJitUopBuffer*trace) | ||
| { | ||
| returntrace->next-trace->start; |
| staticinlineint | ||
| uop_buffer_remaining_space(_PyJitUopBuffer*trace) | ||
| { | ||
| returntrace->end-trace->next; |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first PR of a series to reducing coupling, particularly hidden coupling, in the tracer.
This is a bit of a mixed assortment of small changes to prepare for more significant changes later.
It also fixes a bug that was exposed by the refactoring.