gh-130415: Narrow types to constants in branches involving specialized comparisons with a constant#144150
+360 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
reidenong requested review from Fidget-Spinner, markshannon, savannahostrowski and tomasr8 as code owners
17 tasks
ContributorAuthor
reidenong commented Jan 22, 2026
After discussion with Ken Jin I will be adding implementations for all |
reidenong changed the title 
Fidget-Spinner merged commit 6d972e0 into python:main 68 of 69 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new predicate optimizer symbol to narrow types to constants in branches involving comparisons with a constant.
This PR provides the implementation for
_COMPARE_OP_INT,_COMPARE_OP_STR,_COMPARE_OP_FLOAT.