[3.5] bpo-34155: Dont parse domains containing @ (GH-13079)#15317
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Before: >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses (Address(display_name='', username='a', domain='malicious.org'),) >>> parseaddr('[email protected]@important.com') ('', '[email protected]') After: >>> email.message_from_string('From: [email protected]@important.com', policy=email.policy.default)['from'].addresses (Address(display_name='', username='', domain=''),) >>> parseaddr('[email protected]@important.com') ('', 'a@') https://bugs.python.org/issue34155 (cherry picked from commit 8cb65d1) Co-authored-by: jpic <[email protected]>
Member
alex commented Aug 17, 2019
This needs a review from the 3.5 RM if this is going to be backported. |
Member
vstinner commented Aug 19, 2019
@larryhastings: Would you mind to merge this security fix? |
bedevere-bot commented Sep 7, 2019
@larryhastings: Please replace |
Contributor
larryhastings commented Sep 7, 2019
Thanks for the backport and the 3.5 love! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
https://bugs.python.org/issue34155
(cherry picked from commit 8cb65d1)
Co-authored-by: jpic [email protected]
https://bugs.python.org/issue34155