[3.8] bpo-37947: Avoid double-decrement in symtable recursion counting (GH-15593)#15594
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…honGH-15593) With `symtable_visit_expr` now correctly adjusting the recursion depth for named expressions, `symtable_handle_namedexpr` should be leaving it alone. Also adds a new check to `PySymtable_BuildObject` that raises `SystemError` if a successful first symbol analysis pass fails to keep the stack depth accounting clean. (cherry picked from commit 0614523) Co-authored-by: Nick Coghlan <ncoghlan@gmail.com>
ncoghlan approved these changes Aug 29, 2019
ContributorAuthor
miss-islington commented Aug 29, 2019
@ncoghlan: Status check is done, and it's a success ✅ . |
ContributorAuthor
miss-islington commented Aug 29, 2019
@ncoghlan: Status check is done, and it's a success ✅ . |
1 similar comment
ContributorAuthor
miss-islington commented Aug 29, 2019
@ncoghlan: Status check is done, and it's a success ✅ . |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
symtable_visit_exprnow correctly adjusting the recursion depth for namedexpressions,
symtable_handle_namedexprshould be leaving it alone.Also adds a new check to
PySymtable_BuildObjectthat raisesSystemErrorif a successful first symbol analysis pass fails to keep the stack depth
accounting clean.
(cherry picked from commit 0614523)
Co-authored-by: Nick Coghlan ncoghlan@gmail.com
https://bugs.python.org/issue37947
Automerge-Triggered-By: @ncoghlan