bpo-36876: Add a tool that identifies unsupported global C variables.#15877
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
vstinner commented Sep 10, 2019
115 commits, 51 files changes, and wow, that's a huge PR. |
Member
" bpo-36876: Make sure no new globals get added." So far, the C API don't provide any solution for function "static PyObject *local_global_var = ...;" :-) |
ericsnowcurrentlyforce-pushed the globals-checker branch from 23e9d06 to de1f50fCompareericsnowcurrently changed the title MemberAuthor
ericsnowcurrently commented Sep 11, 2019
Yeah, it's a lot, but it's all under Tools/. :) Also, I've updated the title to be more clear. |
ericsnowcurrentlyforce-pushed the globals-checker branch from de1f50f to 569c57eCompareMemberAuthor
ericsnowcurrently commented Sep 11, 2019
FYI, all the failures are strictly with patchcheck, which is complaining about whitespace in some files. I cannot reproduce that locally. |
bedevere-bot commented Sep 11, 2019
@ericsnowcurrently: Please replace |
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
For now the test is marked as a known failure. I'll be working to fix all of unsupported globals, at which point I'll unmark the test.
Note that this PR adds code to
Tools/c-analyzeror adds new tests. The only existing code I touch is where I factor out an existing testing helper from tests for another tool.https://bugs.python.org/issue36876