Skip to content

Conversation

@eduardo-elizondo
Copy link
Contributor

@eduardo-elizondoeduardo-elizondo commented Sep 13, 2019

This makes tp_dictoffset and tp_weaklistoffset completely opaque for C heap allocated types created through PyType_FromSpec.

The type system already provides a way to pass in readonly primitive types. This uses that mechanism to pass in the offset values through the two keywords: __dictoffset__ and __weaklistoffset__. This then extends the type system to sniff for these values to set the offsets into the type.

To provide uniformity, the passed in member types are required to have a T_PYSSIZET as well as being READONLY

https://bugs.python.org/issue38140

@DinoVDinoV requested a review from encukouSeptember 14, 2019 14:10
@DinoVDinoV merged commit 3368f3c into python:masterSep 19, 2019
@bedevere-bot
Copy link

@DinoV: Please replace # with GH- in the commit message next time. Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@eduardo-elizondo@bedevere-bot@DinoV@the-knights-who-say-ni