bpo-30374: Fixed several bugs in win_add2path.py#1645
Uh oh!
There was an error while loading. Please reload this page.
Conversation
* Discard the DEFAULT "%PATH%" value. * Delete wrong `os.path.isdir()`. * Add absolute path instead of `%APPDATA%...` if the type of PATH is `REG_SZ`. * Broadcast a `WM_SETTINGCHANG` message after the change of env vars. * Add codes to deal with possible errors.
mention-bot commented May 18, 2017
@neEverett, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tiran and @birkenfeld to be potential reviewers. |
zooba left a comment
zooba left a comment There was a problem hiding this comment.
Thanks for this! Overall they are good looking changes, just a few loose ends to tidy up.
Tools/scripts/win_add2path.py Outdated
| importsite | ||
| importos | ||
| importwinreg | ||
| importctypes |
Tools/scripts/win_add2path.py Outdated
| envpath, dtype=winreg.QueryValueEx(key, PATH) | ||
| exceptFileNotFoundError: | ||
| envpath, dtype="", winreg.REG_EXPAND_SZ | ||
| pass |
Tools/scripts/win_add2path.py Outdated
| except: | ||
| raiseOSError("Failed to load PATH value") | ||
| ifhasattr(site, "USER_SITE") anddtype==winreg.REG_EXPAND_SZ: |
There was a problem hiding this comment.
This hasattr check doesn't apply to the subsequent elif block, or rather, if the first check here fails then we may end up crashing in the elif block.
Fixed the problems mentioned here: python#1645
Fixed the problems mentioned here: python#1645
csabella commented Jan 27, 2020
Closing and reopening to retrigger tests. |
This PR is stale because it has been open for 30 days with no activity. |
github-actionsbot removed the stale This PR is stale because it has been open for 30 days with no activity. |
Closing as win_add2path.py was removed in #98167. thanks |
9 participants
DEFAULT = "%PATH%". The system PATH is effective to all users[1] so adding "%PATH%" in user PATH is unnecessary.os.path.isdir()always return False because the input path includes"%APPDATA%"and also because the USER_SITE directory does not yet exist when Python is just installed. It is now deleted to make paths be added correctly."%APPDATA%"effective[2] . However this is not a good practice (brought forward by Eryk Sun in the issue). Now the script does not change the type of PATH. If it's REG_SZ, the absolute path of%APPDATA%will be added instead.WM_SETTINGCHANGmessage[3] after the change of env vars.https://bugs.python.org/issue30374