bpo-23894: Make rb'' strings work in lib2to3#1724
Uh oh!
There was an error while loading. Please reload this page.
Conversation
ambv changed the title ambvforce-pushed the bpo-23894-rb branch 2 times, most recently from 76b0e9d to d330004Compare
Lib/lib2to3/pgen2/tokenize.py Outdated
| # Single-line ' or " string. | ||
| String = group(r"[uU]?[rR]?'[^\n'\\]*(?:\\.[^\n'\\]*)*'", | ||
| r'[uU]?[rR]?"[^\n"\\]*(?:\\.[^\n"\\]*)*"') |
There was a problem hiding this comment.
"String" didn't previously include b but this is suspicious to me. Why wouldn't it? That way b'' literals were only PseudoTokens (via ContStr), not actual Tokens (via String).
ned-deily left a comment
ned-deily left a comment There was a problem hiding this comment.
Thanks for adding the test: LGTM. As far as the tokenizer changes, I'm not familiar enough with lib2to3 to provide a useful review. Assuming other reviewers have no objections, I'm fine for this going into 3.6.2rc.
Tests are failing because I used an f-string in the test and lib2to3 is parsing that test file as part of fixers. f-strings are not supported yet in lib2to3. Switching to using a classic UPDATE: as expected, tests pass now. |
This partially solves bpo-23894.
This partially solves bpo-23894. (cherry picked from commit 0c4aca5)
vstinner commented May 23, 2017
I was requested for a review, but after I completed my review, I see that the change was already merged :-D It's fine, don't worry. I just want to give my post-commit LGTM! Nice change. Thanks @ambv for taking care of 2to3 ;-) |
6 participants
This partially solves bpo-23894. A separate PR coming later to support f-strings.