[3.7] bpo-38588: Fix possible crashes in dict and list when calling P…#17765
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…yObject_RichCompareBool (pythonGH-17734) Take strong references before calling PyObject_RichCompareBool to protect against the case where the object dies during the call.. (cherry picked from commit 2d5bf56) Co-authored-by: Dong-hee Na <[email protected]>
corona10 commented Dec 31, 2019
Uh oh!
There was an error while loading. Please reload this page.
methane reviewed Dec 31, 2019
Uh oh!
There was an error while loading. Please reload this page.
methane's suggestion Co-Authored-By: Inada Naoki <[email protected]>
pablogsal approved these changes Dec 31, 2019
methane approved these changes Dec 31, 2019
corona10 added a commit to corona10/cpython that referenced this pull request Jan 27, 2020
pythonGH-17765) * [3.7] bpo-38588: Fix possible crashes in dict and list when calling PyObject_RichCompareBool (pythonGH-17734) Take strong references before calling PyObject_RichCompareBool to protect against the case where the object dies during the call.. (cherry picked from commit 2d5bf56) Co-authored-by: Dong-hee Na <[email protected]> * methane's suggestion methane's suggestion Co-Authored-By: Inada Naoki <[email protected]> Co-authored-by: Inada Naoki <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…yObject_RichCompareBool (GH-17734)
Take strong references before calling PyObject_RichCompareBool to protect against the case
where the object dies during the call..
(cherry picked from commit 2d5bf56)
Co-authored-by: Dong-hee Na [email protected]
https://bugs.python.org/issue38588