Skip to content

bpo-1635741: Port _json extension module to multiphase initialization(PEP 489)#17835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 7 commits into from
Jan 15, 2020
Merged

bpo-1635741: Port _json extension module to multiphase initialization(PEP 489) #17835

vstinner merged 7 commits into from
Jan 15, 2020

Conversation

@shihai1991
Copy link
Member

@shihai1991shihai1991 commented Jan 5, 2020•
edited by bedevere-bot
Loading

@vstinner
Copy link
Member

vstinner commented Jan 6, 2020

cc @encukou @Dormouse759

vstinner
vstinner reviewed Jan 9, 2020
View reviewed changes
vstinner
vstinner approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinnervstinner merged commit ed154c3 into python:masterJan 15, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@shihai1991
bpo-1635741: Port _json extension module to multiphase initialization…
771fce9
… (PEP 489) (pythonGH-17835)
@erlend-aaslanderlend-aasland mentioned this pull request Jun 28, 2022
Closed
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991@vstinner@the-knights-who-say-ni@bedevere-bot