Py_DECREF: only pass filename if Py_REF_DEBUG is defined#17870
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Filename and line numbers are not needed when Py_REF_DEBUG are not defined. The static inline _Py_DECREF() function was introduced by commit 2aaf0c1.
MemberAuthor
vstinner commented Jan 6, 2020
See PR #16781 for my first attempt. |
MemberAuthor
vstinner commented Jan 6, 2020
@Yhg1s@serhiy-storchaka: Does this version look better than PR #16781? |
MemberAuthor
vstinner commented Jan 8, 2020
cc @pablogsal |
Yhg1s approved these changes Jan 8, 2020
Member
Yhg1s left a comment
Yhg1s left a comment There was a problem hiding this comment.
Yes, this looks better to me. The ifdef dance isn't too bad, and it's no longer duplicating logic.
Include/object.h Outdated
| #endif | ||
| PyObject *op) | ||
| { | ||
| (void)filename; /* may be unused, shut up -Wunused-parameter */ |
Member
There was a problem hiding this comment.
These suppressions shouldn't be necessary anymore, but if they are, they should be conditional.
MemberAuthor
There was a problem hiding this comment.
The suppression are needed with the current code, since filename & fileno are not used for a release build. It's the purpose of my change: don't pass them if we don't need them ;-)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
) Filename and line numbers are not needed when Py_REF_DEBUG are not defined. The static inline _Py_DECREF() function was introduced by commit 2aaf0c1.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filename and line numbers are not needed when Py_REF_DEBUG are not
defined.
The static inline _Py_DECREF() function was introduced by
commit 2aaf0c1.