Skip to content

bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489)#18065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miss-islington merged 2 commits into from
Feb 11, 2020
Merged

bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) #18065

miss-islington merged 2 commits into from
Feb 11, 2020

Conversation

@shihai1991
Copy link
Member

@shihai1991shihai1991 commented Jan 19, 2020•
edited by miss-islington
Loading

ncoghlan
ncoghlan approved these changes Feb 2, 2020
View reviewed changes
Copy link
Contributor

@ncoghlanncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (given the relative simplicity of the module), but until I've reviewed a few more of these, I'd like to get a +1 from @encukou as well.

@encukou
Copy link
Member

encukou commented Feb 4, 2020

The catch it that the simple module exposes complex API, and multiphase init asserts that the module is expected to support sub-interpreters. Any module that manipulates some registry should get some extra attention :)
All looks OK here, since thePyCodec_* functions all use interpreter-specific state.
@Dormouse759, do you want to take a look?

@encukouencukou changed the title bpo-1635741: Port _codecs extension module to multiphase initialization(PEP 489)bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489)Feb 11, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Feb 11, 2020

@shihai1991: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Feb 11, 2020

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islingtonmiss-islington merged commit 1ea45ae into python:masterFeb 11, 2020
@shihai1991
Copy link
MemberAuthor

shihai1991 commented Feb 11, 2020

Thanks, guys.

@encukou
Copy link
Member

encukou commented Feb 11, 2020

Thank you!

@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlanncoghlanncoghlan approved these changes

@encukouencukouAwaiting requested review from encukou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991@encukou@miss-islington@ncoghlan@the-knights-who-say-ni@bedevere-bot