bpo-39401: Avoid unsafe DLL load on Windows 7 and earlier

[zooba]

https://bugs.python.org/issue39401

[bedevere-bot]

GH-18234 is a backport of this pull request to the 3.8 branch.

[zooba]

Two commits in this PR - the first is the backported change, while the second is the "real" change that we want for the future.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit 6a65eba.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/81/builds/272) and take a look at the build logs.
4. Check if the failure is related to this commit (6a65eba) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/81/builds/272

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 9, done. remote: Counting objects: 11% (1/9) remote: Counting objects: 22% (2/9) remote: Counting objects: 33% (3/9) remote: Counting objects: 44% (4/9) remote: Counting objects: 55% (5/9) remote: Counting objects: 66% (6/9) remote: Counting objects: 77% (7/9) remote: Counting objects: 88% (8/9) remote: Counting objects: 100% (9/9) remote: Counting objects: 100% (9/9), done. remote: Compressing objects: 14% (1/7) remote: Compressing objects: 28% (2/7) remote: Compressing objects: 42% (3/7) remote: Compressing objects: 57% (4/7) remote: Compressing objects: 71% (5/7) remote: Compressing objects: 85% (6/7) remote: Compressing objects: 100% (7/7) remote: Compressing objects: 100% (7/7), done. remote: Total 11 (delta 2), reused 2 (delta 2), pack-reused 2  From https://github.com/python/cpython * branch master -> FETCH_HEAD Reset branch 'master' Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\Lib\*.pyc The system cannot find the file specified. Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\python*.zip Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\Lib\*.pyc The system cannot find the file specified. Could Not Find C:\buildbot.python.org\3.x.kloth-win64\build\PCbuild\python*.zip

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Windows7 3.x has failed when building commit 6a65eba.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/150/builds/227) and take a look at the build logs.
4. Check if the failure is related to this commit (6a65eba) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/150/builds/227

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 9, done. remote: Counting objects: 11% (1/9) remote: Counting objects: 22% (2/9) remote: Counting objects: 33% (3/9) remote: Counting objects: 44% (4/9) remote: Counting objects: 55% (5/9) remote: Counting objects: 66% (6/9) remote: Counting objects: 77% (7/9) remote: Counting objects: 88% (8/9) remote: Counting objects: 100% (9/9) remote: Counting objects: 100% (9/9), done. remote: Compressing objects: 14% (1/7) remote: Compressing objects: 28% (2/7) remote: Compressing objects: 42% (3/7) remote: Compressing objects: 57% (4/7) remote: Compressing objects: 71% (5/7) remote: Compressing objects: 85% (6/7) remote: Compressing objects: 100% (7/7) remote: Compressing objects: 100% (7/7), done. remote: Total 11 (delta 2), reused 2 (delta 2), pack-reused 2  From https://github.com/python/cpython * branch master -> FETCH_HEAD Reset branch 'master' The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio n, script file, or operable program. Check the spelling of the name, or if a pa th was included, verify that the path is correct and try again. At line:1 char:18 + Invoke-WebRequest <<<< https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db 3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals \nuget.exe' + CategoryInfo : ObjectNotFound: (Invoke-WebRequest:String) [], C ommandNotFoundException + FullyQualifiedErrorId : CommandNotFoundException 'py' is not recognized as an internal or external command, operable program or batch file. '"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command, operable program or batch file. The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio n, script file, or operable program. Check the spelling of the name, or if a pa th was included, verify that the path is correct and try again. At line:1 char:18 + Invoke-WebRequest <<<< https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db 3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals \nuget.exe' + CategoryInfo : ObjectNotFound: (Invoke-WebRequest:String) [], C ommandNotFoundException + FullyQualifiedErrorId : CommandNotFoundException 'py' is not recognized as an internal or external command, operable program or batch file. '"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command, operable program or batch file. Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Lib\*.pyc The system cannot find the file specified. Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\python*.zip The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio n, script file, or operable program. Check the spelling of the name, or if a pa th was included, verify that the path is correct and try again. At line:1 char:18 + Invoke-WebRequest <<<< https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db 3l\buildarea\3.x.bolen-windows7\build\PCbuild\\..\externals\nuget.exe' + CategoryInfo : ObjectNotFound: (Invoke-WebRequest:String) [], C ommandNotFoundException + FullyQualifiedErrorId : CommandNotFoundException 'py' is not recognized as an internal or external command, operable program or batch file. '"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\\..\externals\nuget.exe"' is not recognized as an internal or external command, operable program or batch file. The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio n, script file, or operable program. Check the spelling of the name, or if a pa th was included, verify that the path is correct and try again. At line:1 char:18 + Invoke-WebRequest <<<< https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db 3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals \nuget.exe' + CategoryInfo : ObjectNotFound: (Invoke-WebRequest:String) [], C ommandNotFoundException + FullyQualifiedErrorId : CommandNotFoundException 'py' is not recognized as an internal or external command, operable program or batch file. '"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command, operable program or batch file. The term 'Invoke-WebRequest' is not recognized as the name of a cmdlet, functio n, script file, or operable program. Check the spelling of the name, or if a pa th was included, verify that the path is correct and try again. At line:1 char:18 + Invoke-WebRequest <<<< https://aka.ms/nugetclidl -OutFile 'D:\cygwin\home\db 3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals \nuget.exe' + CategoryInfo : ObjectNotFound: (Invoke-WebRequest:String) [], C ommandNotFoundException + FullyQualifiedErrorId : CommandNotFoundException 'py' is not recognized as an internal or external command, operable program or batch file. '"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Tools\buildbot\..\..\PCbuild\..\externals\nuget.exe"' is not recognized as an internal or external command, operable program or batch file. Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\Lib\*.pyc The system cannot find the file specified. Could Not Find D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\PCbuild\python*.zip