Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Feb 12, 2020

The whole cellobject.h API is excluded from the limited C API, so
move the header file to Include/cpython/ directory. Since
cellobject.h is included by the main Python.h: users should not be
affected by this change.

https://bugs.python.org/issue35134

The whole content of cellobject.h, classobject.h, genobject.h, pyarena.h, pyctype.h, pydebug.h, pyfpe.h and pytime.h is excluded from the limited C API, so move these header files to Include/cpython/ directory. Since they are included by the main Python.h: users should not be affected by this change. If one of these header file is included explicitly: only include Python.h instead.
@vstinnervstinner changed the title bpo-35134: Move cellobject.h header to Include/cpython/[WIP] bpo-35134: Move header files to Include/cpython/Feb 12, 2020
@codecov
Copy link

codecovbot commented Feb 12, 2020

Codecov Report

Merging #18490 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #18490 +/- ## ========================================= Coverage 82.11% 82.12% ========================================= Files 1956 1955 -1 Lines 589183 583854 -5329 Branches 44448 44449 +1 ========================================= - Hits 483833 479488 -4345 + Misses 95701 94722 -979 + Partials 9649 9644 -5 
Impacted FilesCoverage Δ
Lib/distutils/tests/test_bdist_rpm.py30.00% <0.00%> (-65.00%)⬇️
Lib/distutils/command/bdist_rpm.py7.63% <0.00%> (-56.88%)⬇️
Lib/test/test_urllib2net.py76.92% <0.00%> (-13.85%)⬇️
Lib/test/test_smtpnet.py78.57% <0.00%> (-7.15%)⬇️
Lib/ftplib.py63.85% <0.00%> (-6.06%)⬇️
Lib/test/test_ftplib.py87.11% <0.00%> (-4.72%)⬇️
Tools/scripts/db2pickle.py17.82% <0.00%> (-3.97%)⬇️
Tools/scripts/pickle2db.py16.98% <0.00%> (-3.78%)⬇️
Lib/test/test_socket.py71.94% <0.00%> (-3.77%)⬇️
Lib/test/test_asyncio/test_base_events.py91.84% <0.00%> (-3.30%)⬇️
... and 330 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674935b...c459180. Read the comment docs.

@vstinner
Copy link
MemberAuthor

This change break C extension modules which explicitly include on these moved header files.

A safer approach would be to keep .h files in Include/ but move their content into a new Include/cpython/ file.

I close this PR.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@the-knights-who-say-ni@bedevere-bot