Skip to content

bpo-30514: test_pop3lib asyncore with asyncio#1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
grzgrzgrz3 wants to merge 2 commits into
base:main
Choose a base branch
from
Open

bpo-30514: test_pop3lib asyncore with asyncio #1864

grzgrzgrz3 wants to merge 2 commits into from

Conversation

@grzgrzgrz3
Copy link
Contributor

@grzgrzgrz3grzgrzgrz3 commented May 30, 2017•
edited by JelleZijlstra
Loading

Pop3 server stub was base on asyncore/asynchat which is deprecated, new
stub is using asyncio instead.

test_too_long_lines make sure we read remaining overlong response

cmd_user answer only with +ERR message on invalid user

#74699

@grzgrzgrz3
bpo-30514: test_pop3lib asyncore with asyncio
db49288
Pop3 server stub was base on asyncore/asynchat which is deprecated, new stub is using asyncio instead. test_too_long_lines make sure we read remaining overlong response cmd_user answer only with +ERR message on invalid user
@mention-bot
Copy link

mention-bot commented May 30, 2017

@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @serhiy-storchaka and @giampaolo to be potential reviewers.

@codecov
Copy link

codecovbot commented May 30, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@9c972b5). Click here to learn what that means.
The diff coverage is 97.67%.

Impacted file tree graph

@@ Coverage Diff @@## master #1864 +/- ## ========================================= Coverage ? 82.68% ========================================= Files ? 1432 Lines ? 353405 Branches ? 0 ========================================= Hits ? 292229 Misses ? 61176 Partials ? 0
Impacted FilesCoverage Δ
Lib/test/test_poplib.py98.13% <97.67%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c972b5...996e0cc. Read the comment docs.

@serhiy-storchakaserhiy-storchaka added the tests Tests in the Lib/test dir label Dec 8, 2018
@matrixisematrixise self-assigned this Sep 12, 2019
auvipy
auvipy suggested changes Jul 20, 2021
View reviewed changes
Copy link

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a rebase on top of main branch would be a good first start

@matrixisematrixise removed their assignment Oct 5, 2021
@github-actions
Copy link

github-actionsbot commented Feb 19, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@grzgrzgrz3grzgrzgrz3mannequin mentioned this pull request Apr 11, 2022
Open
@JelleZijlstraJelleZijlstra self-assigned this May 10, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 10, 2022

I'll work on getting this up to date so it unblocks removing asyncore. Note to self: local branch name is bpo30514-grzegorz-grzywacz-poplib.

@github-actionsgithub-actionsbot removed the stale Stale PR or inactive for long period of time. label May 11, 2022
@JelleZijlstraJelleZijlstra mentioned this pull request May 26, 2022
Closed
12 tasks
@AA-Turner
Copy link
Member

AA-Turner commented Jun 7, 2022

Triggering CLA.

@AA-TurnerAA-Turner reopened this Jun 7, 2022
@github-actions
Copy link

github-actionsbot commented Jul 8, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Jul 8, 2022
@github-actionsgithub-actionsbot removed the stale Stale PR or inactive for long period of time. label Oct 10, 2022
@github-actions
Copy link

github-actionsbot commented Nov 10, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Nov 10, 2022
@JelleZijlstraJelleZijlstra removed their assignment Nov 12, 2022
@github-actionsgithub-actionsbot removed the stale Stale PR or inactive for long period of time. label Nov 13, 2022
@github-actions
Copy link

github-actionsbot commented Dec 14, 2022

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Dec 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@auvipyauvipyauvipy requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core reviewstaleStale PR or inactive for long period of time.testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@grzgrzgrz3@mention-bot@JelleZijlstra@AA-Turner@auvipy@matrixise@brettcannon@serhiy-storchaka@Mariatta@the-knights-who-say-ni@bedevere-bot@kumaraditya303@AlexWaygood