bpo-1635741: Enhance get_binascii_state()

[shihai1991]

https://bugs.python.org/issue1635741

[corona10]

Looks good to me.

[corona10]

Looks like _Pickle_GetState needs same change on sperate PR..

cpython/Modules/_pickle.c

Line 183 in dffe4c0

_Pickle_GetState(PyObject*module)

[shihai1991]

Looks like _Pickle_GetState needs same change on sperate PR..

cpython/Modules/_pickle.c

Line 183 in dffe4c0

_Pickle_GetState(PyObject*module)

I create this sperate change due to binascii extension module have been ported to pep-489.
IMO, other extension modules' get_xxx_state() can be done with porting operation.

[shihai1991]

cc @vstinner Hi, victor. It's a enhancement operation of binascii's get_module_state()

[vstinner]

I don't think that this change is worth it. In practice, I don't see why the state would be NULL. If it's the case, the code should crash anyway :-) Existing code which checks that the state is not NULL with an assertion is fine. But I don't think that this change is worth it.

[shihai1991]

got it, thanks, victor :)