Skip to content

bpo-40170: Convert PyObject_CheckBuffer() macro to a function#19376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Apr 7, 2020
Merged

bpo-40170: Convert PyObject_CheckBuffer() macro to a function #19376

vstinner merged 1 commit into from
Apr 7, 2020

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Apr 4, 2020•
edited by bedevere-bot
Loading

Convert PyObject_CheckBuffer() macro to a function to hide
implementation details: the macro accessed directly
PyTypeObject.tp_as_buffer field.

https://bugs.python.org/issue40170

@vstinner
Copy link
MemberAuthor

vstinner commented Apr 5, 2020

PyObject_CheckBuffer() is used for example by:

  • PyBytes_FromObject()
  • PyMemoryView_FromObject()
  • PyUnicode_FSDecoder()
  • PyObject_CopyData()
  • w_complex_object() of marshal.c

@vstinner
bpo-40170: Convert PyObject_CheckBuffer() macro to a function
584cbe1
Convert PyObject_CheckBuffer() macro to a function to hide implementation details: the macro accessed directly the PyTypeObject.tp_as_buffer member.
@vstinnervstinner merged commit ef5c615 into python:masterApr 7, 2020
@vstinnervstinner deleted the check_buffer branch April 7, 2020 23:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@the-knights-who-say-ni@bedevere-bot