bpo-31904: set expected default encoding in test_c_locale_coercion.py for VxWorks RTOS#19448
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vstinner approved these changes Apr 9, 2020
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM.
It's consistent with Include/pyport.h:
#if defined(__ANDROID__) || defined(__VXWORKS__) /* Ignore the locale encoding: force UTF-8 */ # define _Py_FORCE_UTF8_LOCALE #endif I added _Py_FORCE_UTF8_LOCALE to better support platforms where the locale is ignored and we force the usage of the UTF-8 encoding.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far VxWorks RTOS only supports "C" locale and always use utf-8 encoding for the "C" locale.
https://bugs.python.org/issue31904