Skip to content

bpo-1635741: Port mmap module to multiphase initialization#19459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 4 commits into from
Jun 5, 2020
Merged

bpo-1635741: Port mmap module to multiphase initialization #19459

corona10 merged 4 commits into from
Jun 5, 2020

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Apr 10, 2020•
edited by bedevere-bot
Loading

@corona10corona10 changed the title Port mmap module to multiphase initializationbpo-1635741: Port mmap module to multiphase initializationApr 10, 2020
@corona10corona10 requested a review from vstinnerApril 10, 2020 15:31
shihai1991
shihai1991 approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@shihai1991shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

vstinner
vstinner approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. mmap code would deserve better error handling, but that can be addressed in a separated PR.

Apart static types, I don't anything which would be shared by multiple module instances/interpreters.

vstinner
vstinner reviewed Jun 5, 2020
View reviewed changes
vstinner
vstinner reviewed Jun 5, 2020
View reviewed changes
vstinner
vstinner approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart the PyExc_OSError bug.

@corona10corona10 merged commit 3ad52e3 into python:masterJun 5, 2020
@corona10
Copy link
MemberAuthor

corona10 commented Jun 5, 2020

@vstinner@shihai1991 Thanks for the reviews!

@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
@corona10corona10 deleted the bpo-1635741-mmap branch February 15, 2024 01:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@shihai1991shihai1991shihai1991 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10@vstinner@shihai1991@the-knights-who-say-ni@bedevere-bot