Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
bpo-40334: PEP 617: New PEG parser for CPython#19503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
57f78dd5c0c31feab06f391427a4cccfd3d51611b40c7a3820cffa81e960c1589c23851d2b10712f617559abf2014ae717bfa74454c4917b479bd954410737b984cad919a66955101cbca3eeca33b77af3aa1dd4b8ce9a1f3d8888242114a35bedc274736fe4bc4e7c6ba7869ee7b2cfc12c22718743bc3359dab071df9cb1f0bd80627990f2331941dcdc4b8da51f1494114e99a8e2f502dfb7e43370ea7f962d9c36a0f9952d03b68423345d6bf7a54e89ed386c701169db2e764fb2dad52496f6354fb6230061a03e3e3af6081e3c95c9d7e4b5cffee25fb62579785f7400a4c58b504062edf1afe08b8899ec975baa4298650cde6edfbef0f6faa9d309c871cecbecef99b443afb187460d214ab84bFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -13,6 +13,7 @@ on: | ||
| - '**/*.rst' | ||
| pull_request: | ||
| branches: | ||
| - pegen | ||
| - master | ||
| - 3.8 | ||
| - 3.7 | ||
| @@ -50,6 +51,22 @@ jobs: | ||
| build_macos: | ||
| name: 'macOS' | ||
| runs-on: macos-latest | ||
| env: | ||
| PYTHONOLDPARSER: old | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Configure CPython | ||
| run: ./configure --with-pydebug --with-openssl=/usr/local/opt/openssl --prefix=/opt/python-dev | ||
| - name: Build CPython | ||
| run: make -j4 | ||
| - name: Display build info | ||
| run: make pythoninfo | ||
| - name: Tests | ||
| run: make buildbottest TESTOPTS="-j4 -uall,-cpu" | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it really worth it to slow down the pre-commit to test the old parser on different platforms? A single pre-commit job would be enough, no? (Pick your favorite platform.) Or maybe only post-commit buildbots would be enough. | ||
| build_macos_pegen: | ||
| name: 'macOS - Pegen' | ||
| runs-on: macos-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Configure CPython | ||
| @@ -64,6 +81,34 @@ jobs: | ||
| build_ubuntu: | ||
| name: 'Ubuntu' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| OPENSSL_VER: 1.1.1f | ||
| PYTHONOLDPARSER: old | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: Install Dependencies | ||
| run: sudo ./.github/workflows/posix-deps-apt.sh | ||
| - name: 'Restore OpenSSL build' | ||
| id: cache-openssl | ||
| uses: actions/cache@v1 | ||
| with: | ||
| path: ./multissl/openssl/${{env.OPENSSL_VER }} | ||
| key: ${{runner.os }}-multissl-openssl-${{env.OPENSSL_VER }} | ||
| - name: Install OpenSSL | ||
| if: steps.cache-openssl.outputs.cache-hit != 'true' | ||
| run: python3 Tools/ssl/multissltests.py --steps=library --base-directory $PWD/multissl --openssl $OPENSSL_VER --system Linux | ||
| - name: Configure CPython | ||
| run: ./configure --with-pydebug --with-openssl=$PWD/multissl/openssl/$OPENSSL_VER | ||
| - name: Build CPython | ||
| run: make -j4 | ||
| - name: Display build info | ||
| run: make pythoninfo | ||
| - name: Tests | ||
| run: xvfb-run make buildbottest TESTOPTS="-j4 -uall,-cpu" | ||
| build_ubuntu_pegen: | ||
| name: 'Ubuntu - Pegen' | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| OPENSSL_VER: 1.1.1f | ||
| steps: | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| language: c | ||
| dist: xenial | ||
| dist: bionic | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer to change the Travis CI base image in a separated PR. | ||
| # To cache doc-building dependencies and C compiler output. | ||
| cache: | ||
| @@ -22,6 +22,7 @@ env: | ||
| branches: | ||
| only: | ||
| - master | ||
| - pegen | ||
| - /^\d\.\d+$/ | ||
| - buildbot-custom | ||
| @@ -157,7 +158,9 @@ install: | ||
| before_script: | ||
| # -Og is much faster than -O0 | ||
| - CFLAGS="${CFLAGS} -Og" ./configure --with-pydebug | ||
| - make -j4 regen-all | ||
| - eval "$(pyenv init -)" | ||
| - pyenv global 3.8 | ||
| - PYTHON_FOR_REGEN=python3.8 make -j4 regen-all | ||
| - changes=`git status --porcelain` | ||
| - | | ||
| # Check for changes in regenerated files | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -426,6 +426,8 @@ Miscellaneous options | ||
| defines the following possible values: | ||
| * ``-X faulthandler`` to enable :mod:`faulthandler`; | ||
| * ``-X oldparser``: enable the traditional LL(1) parser. See also | ||
| :envvar:`PYTHONOLDPARSER`. | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe the PEP 617 should be mentioned here. I suggest to directly deprecate this option and announces its removal in 3.10 using a Moreover, the new option should be documented in the ".. versionchanged:: 3.9" below. Same remark for PYTHONOLDPARSER. | ||
| * ``-X showrefcount`` to output the total reference count and number of used | ||
| memory blocks when the program finishes or after each statement in the | ||
| interactive interpreter. This only works on debug builds. | ||
| @@ -574,6 +576,12 @@ conflict. | ||
| :option:`-d` multiple times. | ||
| .. envvar:: PYTHONOLDPARSER | ||
| If this is set it is equivalent to specifying the :option:`-X` | ||
| ``oldparser`` option. | ||
| .. envvar:: PYTHONINSPECT | ||
| If this is set to a non-empty string it is equivalent to specifying the | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should be reverted, no?