Skip to content

Conversation

@shihai1991
Copy link
Member

@shihai1991shihai1991 commented Apr 19, 2020

@shihai1991shihai1991 requested a review from vsajip as a code ownerApril 19, 2020 10:41
@shihai1991shihai1991 changed the title bpo-40275: Add loggingutils in test.support[WIP] bpo-40275: Add loggingutils in test.supportApr 19, 2020
@tirkarthi
Copy link
Member

cc: @serhiy-storchaka . There is also similar work at #19601 .

@serhiy-storchaka
Copy link
Member

TestHandler is only used in test_logging. There is no reason to not define it there.

Also, removing import logging from test.support does not help while logging is imported in unittest. #19601 does all necessary to optimize import.

@shihai1991
Copy link
MemberAuthor

TestHandler is only used in test_logging. There is no reason to not define it there.

Oh, thanks. I just left a same question in PR19601.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@shihai1991@tirkarthi@serhiy-storchaka@the-knights-who-say-ni@bedevere-bot