Skip to content

bpo-1635741: Port _stat module to multiphase initialization#19798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 5 commits into from
Apr 29, 2020
Merged

bpo-1635741: Port _stat module to multiphase initialization #19798

corona10 merged 5 commits into from
Apr 29, 2020

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Apr 29, 2020•
edited by bedevere-bot
Loading

vstinner
vstinner reviewed Apr 29, 2020
View reviewed changes
@corona10corona10 requested a review from vstinnerApril 29, 2020 17:23
@corona10
Copy link
MemberAuthor

corona10 commented Apr 29, 2020

@vstinner Please take a look

vstinner
vstinner reviewed Apr 29, 2020
View reviewed changes
vstinner
vstinner reviewed Apr 29, 2020
View reviewed changes
vstinner
vstinner approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the updates!

@corona10corona10 merged commit 84724dd into python:masterApr 29, 2020
@corona10corona10 deleted the bpo-1635741-stat branch April 29, 2020 18:20
@vstinner
Copy link
Member

vstinner commented Apr 30, 2020

The new code emits a compiler warning:

./Modules/_stat.c: In function ‘stat_exec’: ./Modules/_stat.c:566:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (int i = 0; i < Py_ARRAY_LENGTH(st_constants); i++){^

Py_ARRAY_LENGTH() should be casted to int.

cc @corona10

@vstinner
Copy link
Member

vstinner commented Apr 30, 2020

Py_ARRAY_LENGTH() should be casted to int.

After I saw the warning 5 times in a row, I decided to propose a PR for the trivial fix :-)
#19822

@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@vstinner@the-knights-who-say-ni@bedevere-bot