bpo-29587: Enable implicit exception chaining with gen.throw()#19811
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Before this commit, if an exception was active inside a generator when calling gen.throw(), then that exception was lost (i.e. there was no implicit exception chaining). This commit fixes that.
gvanrossum approved these changes Apr 30, 2020
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Looks good to me. I think we should just land this -- if there's something wrong with it we'll shake it out during beta, but it looks likely that it's correct. Thanks for fixing this old bug!
Member
gvanrossum commented Apr 30, 2020
Closing and reopening to re-trigger Azures CI build (that was unstable a while ago, should be better now). |
Member
gvanrossum commented Apr 30, 2020
Whatever; the required tests pass, as do the non-Azure tests. I'll just land. |
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
Member
gvanrossum commented Apr 30, 2020
All these tests pass for me locally, except test_idle which fails because I don't have the right Tcl/Tk installed. What to do? |
Member
vstinner commented Apr 30, 2020
It seems like this change broke tons of buildbots, whereas tests passed on the PR, except on the Ubuntu job of Azure Pipelines.
Either fix it, or revert it. Depending on your availability :-) |
vstinner added a commit that referenced this pull request Apr 30, 2020
vstinner added a commit that referenced this pull request Apr 30, 2020
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
bedevere-bot commented Apr 30, 2020
|
cjerdonek added a commit to cjerdonek/cpython that referenced this pull request Apr 30, 2020
Before this commit, if an exception was active inside a generator when calling gen.throw(), then that exception was lost (i.e. there was no implicit exception chaining). This commit fixes that.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables implicit exception chaining when calling
generator.throw(exc)by settingexc.__context__.This is a naive attempt at fixing this, so I could very well be missing something.
https://bugs.python.org/issue29587