Skip to content

Conversation

@kubo39
Copy link
Contributor

No description provided.

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement
  4. If you just signed the CLA, please wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

Copy link
Member

@methanemethane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@methane
Copy link
Member

I don't think small fix like this doesn't require CLA sign.
But please wait for confirm from other core dev.

@methane
Copy link
Member

I'm sorry. CLA is required.
#19 (comment)

@codecov
Copy link

codecovbot commented Feb 11, 2017

Codecov Report

Merging #20 into master will decrease coverage by -0.01%.

@@ Coverage Diff @@## master #20 +/- ## ========================================== - Coverage 82.37% 82.37% -0.01%  ========================================== Files 1427 1427 Lines 350948 350948 ========================================== - Hits 289091 289089 -2 - Misses 61857 61859 +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29896ad...3f8161b. Read the comment docs.

@vstinner
Copy link
Member

Why is this change tagged with "backport to 3.6"? Was it made in the 3.6 branch? If yes, I suggest to only modify master.

@berkerpeksag
Copy link
Member

Broken links, typo fixes, comment updates etc. usually go to all maintenance branches. 'backport to X.Y' label means this needs to be backported to X.Y branch.

@kubo39
Copy link
ContributorAuthor

I have completed the above steps.

@methane
Copy link
Member

Thanks, friends!

@vstinner
Copy link
Member

Don't forget to update Python 2.7 as well.

jaraco pushed a commit that referenced this pull request Dec 2, 2022
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Feb 2, 2023
20: Warn for missing dict features r=ltratt a=nanjekyejoannah I warn for several features. i looked at this code earlier and had an illusion, for some reason I thought we had these covered until I ran against twisted. Co-authored-by: Joannah Nanjekye <[email protected]>
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Properly prevent namespaces packages from containing resources Closespython#20 See merge request python-devs/importlib_resources!50
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kubo39@the-knights-who-say-ni@methane@vstinner@berkerpeksag