bpo-40784: Fix sqlite3 deterministic test#20448

erlend-aasland · 2020-05-27T10:23:00Z

https://bugs.python.org/issue40784

Lib/sqlite3/test/userfunctions.py

Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner · 2020-05-27T12:58:42Z

Maybe if would be safer to run tests on buildbots to check more SQLite versions, before merging this PR.

Lib/sqlite3/test/userfunctions.py

vstinner

LGTM if CI pass. As I wrote, it sounds worth it to spawn buildbots tests on this PR.

@erlend-aasland: Please stop touching your PR :-) So we can run more tests (buildbots are likely to use more various SQLite versions).

vstinner · 2020-05-27T13:13:49Z

Oh, it may also help if someone could test manually with SQLite 3.32.

erlend-aasland · 2020-05-27T13:15:23Z

Oh, it may also help if someone could test manually with SQLite 3.32.

Already did that, and it passes! 3.32.1 FWIW

vstinner · 2020-05-27T13:29:37Z

Already did that, and it passes! 3.32.1 FWIW

Cool. Thanks!

vstinner · 2020-05-27T15:27:10Z

This still fails. I've fixed CheckFuncNonDeterministic locally but not pushed it yet.

Yeah, the Ubuntu job of Azure Pipelines fails. It uses "sqlite3.sqlite_version: 3.11.0" according to its test.pythoninfo. Test failure:

FAIL: CheckFuncNonDeterministic (sqlite3.test.userfunctions.FunctionTests) Non-deterministic functions cannot be used with partial indices ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/vsts/work/1/s/Lib/sqlite3/test/userfunctions.py", line 288, in CheckFuncNonDeterministic self.assertIn("non-deterministic functions prohibited", str(cm.exception)) AssertionError: 'non-deterministic functions prohibited' not found in 'functions prohibited in partial index WHERE clauses'

Honestly, I don't think that we should test the error message. Please simply remove the test the error message. IMHO excepting an exception is enough.

erlend-aasland · 2020-05-27T18:56:19Z

Yeah, the Ubuntu job of Azure Pipelines fails. It uses "sqlite3.sqlite_version: 3.11.0" according to its test.pythoninfo.

Right. Deterministic functions were allowed in partial indices in sqlite v3.15.0 (2016-10-14). I'll find another way of testing this, then.

Honestly, I don't think that we should test the error message. Please simply remove the test the error message. IMHO excepting an exception is enough.

Agreed. Error messages are likely to change between versions.

erlend-aasland · 2020-05-27T19:11:11Z

@vstinner I suggest just keeping the old tests for SQLite pre v3.15.0. From the sqlite release history:

2014-02-03 (3.8.3) […] Added SQLITE_DETERMINISTIC […] providing applications with the ability to create new functions that can be factored out of inner loops when they have constant arguments.

Seven minor versions later:

2016-10-14 (3.15.0) […] Allow deterministic SQL functions in the WHERE clause of a partial index.

I'll push the change right away.

encukou · 2020-05-28T09:11:30Z

Thank you!
I'll start the buildbots so Victor can continue the review when he gets to the computer.

bedevere-bot · 2020-05-28T09:11:38Z

🤖 New build scheduled with the buildbot fleet by @encukou for commit b969ae5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

erlend-aasland · 2020-05-28T09:19:37Z

Thank you, @encukou!

encukou · 2020-05-28T09:22:31Z

Some failures might not be related to this change.

vstinner · 2020-05-28T13:28:06Z

AMD64 Fedora Stable Clang Installed PR, PPC64LE Fedora Stable Clang Installed PR and s390x Fedora Clang Installed PR and x86 Gentoo Installed with X PR failed because of https://bugs.python.org/issue38488 regression (setuptools/chmod) which is unrelated.

AMD64 FreeBSD Non-Debug PR failures (test_asyncio, test_venv) are unrelated.

AMD64 Windows8.1 Refleaks PR failure (test_socket) is unrelated.

vstinner · 2020-05-28T14:09:54Z

(this comment is unrelated to test_sqlite)

AMD64 Fedora Stable Clang Installed PR, PPC64LE Fedora Stable Clang Installed PR and s390x Fedora Clang Installed PR and x86 Gentoo Installed with X PR failed because of https://bugs.python.org/issue38488 regression (setuptools/chmod) which is unrelated.

I reverted the change which introduced this issue: see https://bugs.python.org/issue38488

AMD64 FreeBSD Non-Debug PR failures (test_asyncio, test_venv) are unrelated.

test_asyncio: test_sock_client_racing() failed, see https://bugs.python.org/issue30064. I created #20485 (merged) to skip the test.

The test_venv is also related to https://bugs.python.org/issue38488 that I reverted: I created https://bugs.python.org/issue40808

AMD64 Windows8.1 Refleaks PR failure (test_socket) is unrelated.

0:41:43 load avg: 6.17 [206/424/1] test_socket failed (41.9 sec) -- running: test_multiprocessing_spawn (41 min 20 sec), test_regrtest (5 min 37 sec) beginning 6 repetitions 123456 Warning -- threading._dangling was modified by test_socket Before:{<weakref at 0x000000B0E9AE4530; to '_MainThread' at 0x000000B0E9935E10>} After:{<weakref at 0x000000B0EC3A1D10; to '_MainThread' at 0x000000B0E9935E10>, <weakref at 0x000000B0EC3A1D70; to 'Thread' at 0x000000B0EBEDD820>, <weakref at 0x000000B0EC3A1DD0; to 'Thread' at 0x000000B0EBEDD690>, <weakref at 0x000000B0EC3A1E30; to 'Thread' at 0x000000B0EBEDD730>, <weakref at 0x000000B0EC3A1E90; to 'Thread' at 0x000000B0EBEDD780>} test test_socket failed -- Traceback (most recent call last): File "D:\buildarea\pull_request.ware-win81-release.refleak\build\lib\test\test_socket.py", line 369, in _tearDown self.wait_threads.__exit__(None, None, None) File "D:\buildarea\pull_request.ware-win81-release.refleak\build\lib\contextlib.py", line 124, in __exit__ next(self.gen) File "D:\buildarea\pull_request.ware-win81-release.refleak\build\lib\test\support\threading_helper.py", line 101, in wait_threads_exit gc_collect() NameError: name 'gc_collect' is not defined

This one looks like a combo:

test_socket leaks a thread
test.support.threading_helper.wait_threads_exit() has a regression: see bpo-40275: Fix a calling bug in threading_helper #20479

erlend-aasland · 2020-05-28T17:35:21Z

Thanks for the review, @berkerpeksag & @vstinner !

berkerpeksag · 2020-05-28T23:28:32Z

Thanks for the PR!

miss-islington · 2020-05-29T12:26:21Z

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington · 2020-05-29T12:26:21Z

Thanks @erlend-aasland for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

bedevere-bot · 2020-05-29T12:26:33Z

GH-20512 is a backport of this pull request to the 3.8 branch.

(cherry picked from commit c610d97) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot · 2020-05-29T12:26:42Z

GH-20513 is a backport of this pull request to the 3.9 branch.

(cherry picked from commit c610d97) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

vstinner · 2020-05-29T13:06:54Z

Thanks for fixing the encoding/copyright line ;-)

bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448) (cherry picked from commit c610d97) (cherry picked from commit 00a240b) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* 'master' of github.com:python/cpython: (497 commits) bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748) bpo-40798: Generate a different message for already removed elements (pythonGH-20483) closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149) bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951) bpo-29882: Add an efficient popcount method for integers (python#771) Further de-linting of zoneinfo module (python#20499) bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435) Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509) bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620) bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448) bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494) Note the output ordering of combinatoric functions (pythonGH-19732) bpo-40474: Updated coverage.yml to better report coverage stats (python#19851) bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492) bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332) bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489) bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493) bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339) bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177) bpo-40275: Fix test.support.threading_helper (pythonGH-20488) ...

SQLite 3.38 introduced some breaking changes in Python 3.8.3 tests. This is fixed by a patch for now (patch merged upstream) python/cpython#20448

Fix sqlite3 deterministic test
40542ba

erlend-aasland requested a review from berkerpeksag as a code owner May 27, 2020 10:23

the-knights-who-say-ni added the CLA signed label May 27, 2020

bedevere-bot added the awaiting review label May 27, 2020

vstinner reviewed May 27, 2020
View reviewed changes

Lib/sqlite3/test/userfunctions.py Outdated Show resolvedHide resolved

Update Lib/sqlite3/test/userfunctions.py
f7f9ef1
Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner reviewed May 27, 2020
View reviewed changes

Lib/sqlite3/test/userfunctions.pyShow resolvedHide resolved

Revert non-ascii change in header
4664279

vstinner approved these changes May 27, 2020
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels May 27, 2020

Use old test for sqlite < 3.15.0
b969ae5

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 28, 2020

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 28, 2020

erlend-aasland requested a review from vstinner May 28, 2020 11:20

vstinner mentioned this pull request May 28, 2020
bpo-40275: Fix a calling bug in threading_helper #20479
Closed

berkerpeksag added the skip news label May 28, 2020

Update userfunctions.py
ad7206e

berkerpeksag approved these changes May 28, 2020
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels May 28, 2020

berkerpeksag merged commit c610d97 into python:masterMay 28, 2020

bedevere-bot removed the awaiting merge label May 28, 2020

erlend-aasland deleted the fix-issue-40784 branch May 29, 2020 05:43

vstinner added needs backport to 3.8 labels May 29, 2020

bedevere-bot removed the needs backport to 3.8 label May 29, 2020

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2020
bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448)
84a70e0
(cherry picked from commit c610d97) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot removed the needs backport to 3.9 label May 29, 2020

miss-islington added a commit that referenced this pull request May 29, 2020
bpo-40784: Fix sqlite3 deterministic test (GH-20448)
00a240b
(cherry picked from commit c610d97) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

miss-islington added a commit that referenced this pull request May 29, 2020
bpo-40784: Fix sqlite3 deterministic test (GH-20448)
8fcc147
(cherry picked from commit c610d97) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

vstinner mentioned this pull request May 29, 2020
00350: SQLite fix deterministic test fedora-python/cpython#11
Merged

algitbot pushed a commit to alpinelinux/aports that referenced this pull request Jul 11, 2020
main/python3: fix sqlite 3.38 tests failure
d5cbbe2
SQLite 3.38 introduced some breaking changes in Python 3.8.3 tests. This is fixed by a patch for now (patch merged upstream) python/cpython#20448

erlend-aasland mentioned this pull request Jan 6, 2021
bpo-40823: Use loadTestsFromTestCase() iso. makeSuite() in sqlite3 tests #20538
Merged

Uh oh!

bpo-40784: Fix sqlite3 deterministic test#20448

bpo-40784: Fix sqlite3 deterministic test #20448

Uh oh!

Conversation

erlend-aasland commented May 27, 2020• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vstinner commented May 27, 2020

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

vstinner commented May 27, 2020

Uh oh!

erlend-aasland commented May 27, 2020

Uh oh!

vstinner commented May 27, 2020

Uh oh!

vstinner commented May 27, 2020

Uh oh!

erlend-aasland commented May 27, 2020

Uh oh!

erlend-aasland commented May 27, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

encukou commented May 28, 2020

Uh oh!

bedevere-bot commented May 28, 2020

Uh oh!

erlend-aasland commented May 28, 2020

Uh oh!

encukou commented May 28, 2020

Uh oh!

vstinner commented May 28, 2020

Uh oh!

vstinner commented May 28, 2020

Uh oh!

erlend-aasland commented May 28, 2020

Uh oh!

berkerpeksag commented May 28, 2020

Uh oh!

miss-islington commented May 29, 2020

Uh oh!

miss-islington commented May 29, 2020

Uh oh!

bedevere-bot commented May 29, 2020

Uh oh!

bedevere-bot commented May 29, 2020

Uh oh!

vstinner commented May 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

erlend-aasland commented May 27, 2020•
edited by bedevere-bot
Loading

erlend-aasland commented May 27, 2020•
edited
Loading