Skip to content

Conversation

@mdickinson
Copy link
Member

@mdickinsonmdickinson commented May 27, 2020

This PR fixes some out-of-date comments in longobject.c.

EDIT: updated to also remove outdated mentions of __int__ from the C-API documentation.

See also #15636.

https://bugs.python.org/issue37999

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to catch it!

Using :meth:`__int__` is deprecated.
.. versionchanged:: 3.10
This function will no longer use :meth:`__int__`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually also remove corresponding deprecated directives when the deprecated feature has been removed. So I suggest to remove deprecated few lines above.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mdickinsonmdickinson merged commit 20941de into python:masterMay 27, 2020
@mdickinsonmdickinson deleted the fix/long-object-function-descriptions branch May 27, 2020 12:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mdickinson@serhiy-storchaka@the-knights-who-say-ni@bedevere-bot