Skip to content

bpo-40801: Add operator.as_float#20481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mdickinson wants to merge 3 commits into from
Closed

bpo-40801: Add operator.as_float #20481

mdickinson wants to merge 3 commits into from

Conversation

@mdickinson
Copy link
Member

@mdickinsonmdickinson commented May 28, 2020•
edited by bedevere-bot
Loading

This PR exposes PyFloat_AsDouble to Python level in the form operator.as_float. This provides a way for Python code to emulate the implicit float conversions that Python itself does at C level.

https://bugs.python.org/issue40801

mdickinson
mdickinson commented May 28, 2020
View reviewed changes
mdickinson
mdickinson commented May 28, 2020
View reviewed changes
mdickinson
mdickinson commented May 28, 2020
View reviewed changes
@mdickinsonmdickinson added the type-feature A feature request or enhancement label May 28, 2020
csabella
csabella reviewed May 28, 2020
View reviewed changes
Lib/operator.py
pass

if bad_type:
raise TypeError(f"must be real number, not{obj.__class__.__name__}")
Copy link
Contributor

@csabellacsabellaMay 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean real number in the math sense? Or do you mean it as instead of a string representation of a number?

Copy link
MemberAuthor

@mdickinsonmdickinsonMay 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mathematical sense. But this wording isn't new to this PR; it's copied from here.

Copy link
Contributor

@csabellacsabellaMay 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That makes sense. :-)

@mdickinsonmdickinson marked this pull request as draft May 29, 2020 09:59
@mdickinson
Copy link
MemberAuthor

mdickinson commented May 29, 2020

Converted this PR to draft; the feature is still under discussion.

@mdickinsonmdickinson deleted the feature/operator-as-float branch June 12, 2021 08:59
@mdickinsonmdickinson mentioned this pull request Oct 6, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csabellacsabellacsabella left review comments

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner will be requested when the pull request is marked ready for reviewAA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core reviewtype-featureA feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdickinson@csabella@the-knights-who-say-ni@bedevere-bot