bpo-40862: Raise TypeError when const is given to argparse.BooleanOptionalAction#20623
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hauntsaninja approved these changes Jun 4, 2020
Contributor
hauntsaninja left a comment
hauntsaninja left a comment There was a problem hiding this comment.
Thanks, lgtm apart from comment nit
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Shantanu <hauntsaninja@users.noreply.github.com>
rhettinger approved these changes Jun 5, 2020
Contributor
miss-islington commented Jun 5, 2020
Thanks @remilapeyre for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
bedevere-bot commented Jun 5, 2020
GH-20664 is a backport of this pull request to the 3.9 branch. |
rhettinger pushed a commit that referenced this pull request Jun 6, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40862