Skip to content

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Jun 13, 2020

@corona10
Copy link
MemberAuthor

@shihai1991 PTAL!

@corona10
Copy link
MemberAuthor

corona10 commented Jun 13, 2020

I' ve checked the memory leak with these scripts and no leaks found

./python.exe -m test test_dbm -R 3:3 
deftest_dbm(self): code=textwrap.dedent(r""" import glob import test.support dbm = test.support.import_module('_dbm') _fname = test.support.TESTFN def delete_files(): for f in glob.glob(_fname + "*"): test.support.unlink(f) f = dbm.open(_fname, 'n') f[b'g'] = b"indented" f.close() delete_files() """) ret=test.support.run_in_subinterp(code) self.assertEqual(ret, 0)

Copy link
MemberAuthor

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shihai1991 Thanks shihai! I've updated it

Copy link
Member

@shihai1991shihai1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Copy link
MemberAuthor

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes; please review again

@corona10corona10 requested a review from vstinnerJune 15, 2020 15:05
corona10and others added 2 commits June 16, 2020 00:20
Co-authored-by: Victor Stinner <vstinner@python.org>
@corona10corona10 requested a review from vstinnerJune 15, 2020 15:24
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's now much better!

@corona10corona10 requested a review from vstinnerJune 15, 2020 15:56
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@corona10corona10 merged commit bf69a8f into python:masterJun 15, 2020
@corona10corona10 deleted the bpo-1635741-dbm branch June 15, 2020 16:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10@bedevere-bot@vstinner@shihai1991@the-knights-who-say-ni