Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
bpo-31938: Fix default-value signatures of several functions in the select module#21066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
asottile commented Jun 23, 2020 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
taleinat commented Jun 23, 2020 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
If this is the proper way to do it, this PR should also fix the default values for |
vstinner commented Jun 23, 2020
Oops, I didn't notice that you proposed a PR and so I wrote PR #21067 which is the same fix :-) Copy of my comment there. inspect.signature() doesn't see the event_mask. Is it a bug in signature which doesn't support a signature written on two lines? cc @serhiy-storchaka@1st1@ambv So pydoc doesn't show the whole signature: |
vstinner commented Jun 23, 2020
IMO the fix is correct, so I concur thta the two other functions signature should also be fixed. By the way, I suggest to rephase the NEWS entry to explain that the change fix the "signature" rather than fixing "pydoc". |
8f69adc to ea850dfCompareasottile commented Jun 23, 2020
I fixed a few others as well -- good catch |
miss-islington commented Jun 23, 2020
miss-islington commented Jun 23, 2020
Sorry, @asottile and @vstinner, I could not cleanly backport this to |
miss-islington commented Jun 23, 2020
Sorry @asottile and @vstinner, I had trouble checking out the |
vstinner commented Jun 23, 2020
@asottile: Automated backport failed. Can you try to backport it manually (use cherry_picker or git cherry-pick -x)? |
…elect module (pythonGH-21066) (cherry picked from commit d051801)
bedevere-bot commented Jun 23, 2020
GH-21097 is a backport of this pull request to the 3.9 branch. |
bedevere-bot commented Jun 23, 2020
GH-21098 is a backport of this pull request to the 3.8 branch. |
…elect module (pythonGH-21066) (cherry picked from commit d051801)
vstinner commented Jun 23, 2020 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading. Please reload this page.
pydoc doesn't show the eventmask parameter whereas it is in select.epoll.register.text_signature. I created bpo-41095: "inspect.signature() doesn't parse text_signature containing a newline character". |
this appears to have regressed in 6dc57e2
https://bugs.python.org/issue31938