Skip to content

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing#21104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iritkatriel merged 2 commits into from
Nov 27, 2022
Merged

gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing #21104

iritkatriel merged 2 commits into from
Nov 27, 2022

Conversation

@asottile
Copy link
Contributor

@asottileasottile commented Jun 24, 2020•
edited by bedevere-bot
Loading

@asottileasottileforce-pushed the inspect_signature_simplify branch from 5309efa to 847fd9fCompareSeptember 3, 2020 18:10
@asottileasottileforce-pushed the inspect_signature_simplify branch from 847fd9f to e569169CompareNovember 2, 2021 02:24
@asottileasottileforce-pushed the inspect_signature_simplify branch from e569169 to 477c2ebCompareJuly 8, 2022 16:27
@asottileasottileforce-pushed the inspect_signature_simplify branch from 477c2eb to 83f9192CompareAugust 5, 2022 20:22
@asottile
Copy link
ContributorAuthor

asottile commented Aug 29, 2022

@1st1 (inspect expert) -- been sitting on this small fix for a few years -- any chance of a review ?

@asottileasottileforce-pushed the inspect_signature_simplify branch from 83f9192 to e6eaf8eCompareOctober 5, 2022 21:16
@iritkatrieliritkatriel changed the title Simplify routine in inspect.signature parsingremove unused 'invalid' variable in inspect.signature parsingNov 27, 2022
@iritkatrieliritkatriel changed the title remove unused 'invalid' variable in inspect.signature parsingremove unused 'invalid' value in inspect.signature parsingNov 27, 2022
@iritkatrieliritkatriel changed the title remove unused 'invalid' value in inspect.signature parsinggh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsingNov 27, 2022
@bedevere-botbedevere-bot mentioned this pull request Nov 27, 2022
Closed
@iritkatrieliritkatriel merged commit ac115b5 into python:mainNov 27, 2022
@JelleZijlstraJelleZijlstra mentioned this pull request Dec 12, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

+1 more reviewer

@eamanueamanueamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@asottile@iritkatriel@eamanu@the-knights-who-say-ni@ezio-melotti@bedevere-bot@kumaraditya303