Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Aug 3, 2020

On Windows, fix asyncio recv_into() return value when the socket/pipe
is closed (BrokenPipeError): return 0 rather than an empty byte
string (b'').

https://bugs.python.org/issue41467

On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b'').
@vstinner
Copy link
MemberAuthor

cc @pitrou

@vstinner
Copy link
MemberAuthor

"Tests / Ubuntu (pull_request) Failing" is unrelated:

0:26:21 load avg: 0.00 [423/423/1] test_ttk_guionly crashed (Exit code 1) Timeout (0:20:00)! Thread 0x00007f2b20812080 (most recent call first): File "/home/runner/work/cpython/cpython/Lib/tkinter/__init__.py", line 697 in wait_visibility File "/home/runner/work/cpython/cpython/Lib/tkinter/test/test_ttk/test_widgets.py", line 452 in test_virtual_event File "/home/runner/work/cpython/cpython/Lib/unittest/case.py", line 549 in _callTestMethod 

@vstinnervstinner merged commit 602a971 into python:masterAug 4, 2020
@vstinnervstinner deleted the asyncio_recv_into branch August 4, 2020 00:40
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2020
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b''). (cherry picked from commit 602a971) Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-21724 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 4, 2020
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b''). (cherry picked from commit 602a971) Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-21726 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Aug 4, 2020
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b''). (cherry picked from commit 602a971) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Aug 4, 2020
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b''). (cherry picked from commit 602a971) Co-authored-by: Victor Stinner <vstinner@python.org>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b'').
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b'').
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b'').
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner@miss-islington@bedevere-bot@the-knights-who-say-ni