Skip to content

Conversation

@shihai1991
Copy link
Member

@shihai1991shihai1991 commented Aug 5, 2020

Use test helpers in the following test cases:

  • test_dbm_gnu
  • test_faulthandler
  • test_grp
  • test_dbm_gnu
  • test_faulthandler
  • test_grp
  • test_http_cookiejar
  • test_httpservers
  • test_import
  • test_ntpath
  • test_site
  • test_socketserver
  • test_statistics
  • test_tabnanny
  • test_tcl
  • test_md5sum
  • test_turtle
  • test_urllib2net
  • test_urllibnet
  • test_webbrowser
  • test_winsound
  • test_tkinter

https://bugs.python.org/issue40275

@shihai1991shihai1991force-pushed the bpo_40275_helper_replace_17 branch 2 times, most recently from 1abdbff to cc5a557CompareAugust 5, 2020 15:06
@shihai1991shihai1991force-pushed the bpo_40275_helper_replace_17 branch from cc5a557 to d4f0586CompareAugust 6, 2020 04:35
@shihai1991shihai1991 requested a review from tiran as a code ownerAugust 6, 2020 04:35
@shihai1991shihai1991 changed the title [WIP] Remove import test helper in test.supportbpo-40275: Use new test.support helper submodules in testsAug 6, 2020
@shihai1991
Copy link
MemberAuthor

cc @vstinner

@vstinner
Copy link
Member

@shihai1991: How many remaining tests need to be patched? Do you have an estimation?

@vstinnervstinner merged commit 79bb2c9 into python:masterAug 6, 2020
@shihai1991
Copy link
MemberAuthor

@shihai1991: How many remaining tests need to be patched? Do you have an estimation?

I have ported all tests what I can test in my centos vm. To some testcases which runs in windows and macos I depend ci gate to estimate.
I estimate it's between 5 to 8(not too exact)

@vstinner
Copy link
Member

I estimate it's between 5 to 8(not too exact)

That's great!

I have ported all tests what I can test in my centos vm. To some testcases which runs in windows and macos I depend ci gate to estimate.

You can write a test/WIP PR which removes aliases in test.support and see which tests fail.

@shihai1991
Copy link
MemberAuthor

You can write a test/WIP PR which removes aliases in test.support and see which tests fail.

yep. I have already did this ; )

shihai1991 added a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991@vstinner@the-knights-who-say-ni@bedevere-bot