Skip to content

Conversation

@shihai1991
Copy link
Member

@shihai1991shihai1991 commented Aug 7, 2020

@shihai1991shihai1991 changed the title bpo-40275: Use new test.support helper submodules in tests[WIP] bpo-40275: Use new test.support helper submodules in testsAug 7, 2020
@shihai1991shihai1991 changed the title [WIP] bpo-40275: Use new test.support helper submodules in testsbpo-40275: Use new test.support helper submodules in testsAug 7, 2020
@shihai1991shihai1991force-pushed the bpo_40275_helper_replace_19 branch from ee875f9 to f592ee3CompareAugust 7, 2020 12:15
@vstinner
Copy link
Member

Strange. "Tests / Check for source changes (pull_request)" failed with "fatal: origin/master...HEAD: no merge base".

 shell: /bin/bash -e{0} Run if [ -z "GITHUB_BASE_REF" ]; then if [ -z "GITHUB_BASE_REF" ]; then echo '::set-output name=run_tests::true' else git fetch origin $GITHUB_BASE_REF --depth=1 git diff --name-only origin/$GITHUB_BASE_REF... | grep -qvE '(\.rst$|^Doc|^Misc)' && echo '::set-output name=run_tests::true' || true fi shell: /bin/bash -e{0} From https://github.com/python/cpython * branch master -> FETCH_HEAD * [new branch] master -> origin/master fatal: origin/master...HEAD: no merge base 

https://github.com/python/cpython/pull/21764/checks?check_run_id=958183690

@shihai1991
Copy link
MemberAuthor

Strange. "Tests / Check for source changes (pull_request)" failed with "fatal: origin/master...HEAD: no merge base".

 shell: /bin/bash -e{0} Run if [ -z "GITHUB_BASE_REF" ]; then if [ -z "GITHUB_BASE_REF" ]; then echo '::set-output name=run_tests::true' else git fetch origin $GITHUB_BASE_REF --depth=1 git diff --name-only origin/$GITHUB_BASE_REF... | grep -qvE '(\.rst$|^Doc|^Misc)' && echo '::set-output name=run_tests::true' || true fi shell: /bin/bash -e{0} From https://github.com/python/cpython * branch master -> FETCH_HEAD * [new branch] master -> origin/master fatal: origin/master...HEAD: no merge base 

https://github.com/python/cpython/pull/21764/checks?check_run_id=958183690

Oh, meet this problem again. I already open an thread in: https://discuss.python.org/t/why-the-ci-gate-in-fork-repo-has-been-disabled/4909.
Looks like nobody know the reason.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

It failed on Windows:

ERROR: setUpClass (test.test_asyncio.test_proactor_events.ProactorEventLoopUnixSockSendfileTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "d:\a\1\s\lib\test\test_asyncio\test_proactor_events.py", line 937, in setUpClass with open(os_helper.TESTFN, 'wb') as fp: NameError: name 'os_helper' is not defined 

@shihai1991
Copy link
MemberAuthor

It failed on Windows:

ERROR: setUpClass (test.test_asyncio.test_proactor_events.ProactorEventLoopUnixSockSendfileTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "d:\a\1\s\lib\test\test_asyncio\test_proactor_events.py", line 937, in setUpClass with open(os_helper.TESTFN, 'wb') as fp: NameError: name 'os_helper' is not defined 

updated.

@vstinner
Copy link
Member

updated

Ah, maybe the GitHub UI pointed me to the wrong build. Now I see that Azure Pipelines is running again.

@shihai1991
Copy link
MemberAuthor

updated

Ah, maybe the GitHub UI pointed me to the wrong build. Now I see that Azure Pipelines is running again.

Your are right. I have push a commit again: )

@shihai1991
Copy link
MemberAuthor

Strange. "Tests / Check for source changes (pull_request)" failed with "fatal: origin/master...HEAD: no merge base".

 shell: /bin/bash -e{0} Run if [ -z "GITHUB_BASE_REF" ]; then if [ -z "GITHUB_BASE_REF" ]; then echo '::set-output name=run_tests::true' else git fetch origin $GITHUB_BASE_REF --depth=1 git diff --name-only origin/$GITHUB_BASE_REF... | grep -qvE '(\.rst$|^Doc|^Misc)' && echo '::set-output name=run_tests::true' || true fi shell: /bin/bash -e{0} From https://github.com/python/cpython * branch master -> FETCH_HEAD * [new branch] master -> origin/master fatal: origin/master...HEAD: no merge base 

https://github.com/python/cpython/pull/21764/checks?check_run_id=958183690

Looks like ... in `git diff --name-only origin/$GITHUB_BASE_REF... ' is redundant(I am not sure about it).
But It is worked actually after I removed it: https://github.com/shihai1991/cpython/pull/28/files

@vstinnervstinner merged commit 598a951 into python:masterAug 7, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shihai1991@vstinner@the-knights-who-say-ni@bedevere-bot