bpo-41514: Fix buggy IDLE test#21808
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot.
terryjreedy added type-bug 
vstinner approved these changes Aug 10, 2020
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM.
./python -m test -u all -R 3:3 -v test_idle pass on Linux with this change.
Contributor
miss-islington commented Aug 10, 2020
@terryjreedy: Status check is done, and it's a success ✅ . |
Contributor
miss-islington commented Aug 10, 2020
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
bedevere-bot commented Aug 10, 2020
GH-21809 is a backport of this pull request to the 3.9 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2020
test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot. (cherry picked from commit 416f0b7) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
bedevere-bot commented Aug 10, 2020
GH-21810 is a backport of this pull request to the 3.8 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 10, 2020
test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot. (cherry picked from commit 416f0b7) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Aug 10, 2020
test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot. (cherry picked from commit 416f0b7) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Aug 10, 2020
test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot. (cherry picked from commit 416f0b7) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot.
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
test_run method test_fatal_error failed when run twice, as with python -m test -m test_fatal_error test_idle test_idle because func.called was not reinitialized to 0. This bug caused a failure on a refleak buildbot.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_run method test_fatal_error failed when run twice, as with
python -m test -m test_fatal_error test_idle test_idle
because func.called was not reinitialized to 0.
This bug caused a failure on a refleak buildbot.
https://bugs.python.org/issue41514