Skip to content

bpo-1635741: port blake2 module to multi-phase init#21856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 11 commits into from
Sep 2, 2020
Merged

bpo-1635741: port blake2 module to multi-phase init #21856

vstinner merged 11 commits into from
Sep 2, 2020

Conversation

@koubaa
Copy link
Contributor

@koubaakoubaa commented Aug 13, 2020•
edited by bedevere-bot
Loading

@koubaakoubaa requested a review from tiran as a code ownerAugust 13, 2020 12:23
@koubaakoubaa mentioned this pull request Aug 13, 2020
Merged
@koubaakoubaaforce-pushed the bpo-1635741-blake2 branch from d282ca9 to abb51feCompareAugust 21, 2020 23:49
@koubaa
Copy link
ContributorAuthor

koubaa commented Aug 29, 2020

@vstinner@shihai1991 This is ready for review

vstinner
vstinner reviewed Aug 29, 2020
View reviewed changes
vstinner
vstinner approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor suggestion on the NEWS entry (please update it).

But right now, I cannot merge the PR: https://mail.python.org/archives/list/python-dev@python.org/thread/KMXK6BQWQZRR2TGVRLECMR7CUVIVTUMQ/

Please ping me when the workflow will be repaired, so I will merge your PR.

@koubaa
Copy link
ContributorAuthor

koubaa commented Sep 1, 2020

@vstinner looks like the doc issue is fixed in the CI.

@vstinnervstinner merged commit a7f0268 into python:masterSep 2, 2020
@vstinner
Copy link
Member

vstinner commented Sep 2, 2020

Merged, thanks @koubaa.

@corona10corona10 mentioned this pull request Sep 10, 2020
Closed
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa
bpo-1635741: Port _blake2 module to multi-phase init (pythonGH-21856)
79cb7a5
Port the _blake2 extension module to the multi-phase initialization API (PEP 489).
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@tirantiranAwaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koubaa@vstinner@the-knights-who-say-ni@bedevere-bot