Skip to content

Conversation

@koubaa
Copy link
Contributor

@koubaakoubaa commented Sep 1, 2020

@koubaa
Copy link
ContributorAuthor

@shihai1991@vstinner I split this from the other PR

@koubaa
Copy link
ContributorAuthor

I can't reproduce the windows test error locally. @vstinner could there be a flake in test_asyncio?

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the windows test error locally. @vstinner could there be a flake in test_asyncio?

test_asyncio contains many race conditions. You're welcome to attempt to fix them :-) Search open issues in the "asyncio" component of https://bugs.python.org/ if you would like ot help.

{NULL, NULL, 0, NULL}
};

staticPyModuleDef_Slotopcode_slots[] ={
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is now empty and so became useless. Please remove it.

@vstinnervstinner merged commit 426f2b4 into python:masterSep 7, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
* origin/master: (1373 commits) bpo-1635741: Port mashal module to multi-phase init (python#22149) bpo-1635741: Port _string module to multi-phase init (pythonGH-22148) bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134) bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139) bpo-41732: add iterator to memoryview (pythonGH-22119) bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909) bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511) bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092) bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986) bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051) bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050) bpo-1635741 port zlib module to multi-phase init (pythonGH-21995) [doc] Add link to Generic in typing (pythonGH-22125) bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123) bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818) closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110) [doc] Fix padding in some typing definitions (pythonGH-22114) Fix documented Python version for venv --upgrade-deps (pythonGH-22113) bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581) bpo-41687: Fix sendfile implementation to work with Solaris (python#22040) ...
@koubaakoubaa deleted the bpo-1635741-opcode branch September 11, 2020 02:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@koubaa@vstinner@shihai1991@the-knights-who-say-ni@bedevere-bot