bpo-41790: update error in documentation#22242
Uh oh!
There was an error while loading. Please reload this page.
Conversation
koubaa commented Sep 14, 2020
@vstinner@corona10@shihai1991 I'm sure I have the wrong issue number but wanted to propose this change to the doc. I can change the number and rebase. |
vstinner commented Sep 14, 2020
You have the wrong issue number. |
koubaa changed the title koubaa commented Sep 15, 2020
@vstinner I made a new issue in that case. |
Misc/NEWS.d/next/Core and Builtins/2020-09-14-13-40-18.bpo-1635741.o6PrOV.rst Outdated Show resolvedHide resolved
Uh oh!
There was an error while loading. Please reload this page.
koubaaforce-pushed the bpo-1635741-doc branch from 1482eab to 098273fComparekoubaa commented Sep 20, 2020
@vstinner is anything else needed before merging this? |
koubaa commented Nov 15, 2020
@vstinner bump |
| declared. The sole exception are the type objects; since these must never be | ||
| deallocated, they are typically static :c:type:`PyTypeObject` objects. | ||
| declared. The sole exception are the type objects; they may be static | ||
| :c:type:`PyTypeObject` objects. |
There was a problem hiding this comment.
"The sole exception are the type objects" looks wrong to me. Almost all types in Python are allocated on the heap.
Only static types are never deallocated.
I'm not sure why these kinds of technical details are giving in an introduction. It would be better to move them to https://docs.python.org/dev/c-api/refcounting.html no?
There was a problem hiding this comment.
Hm, I am not find the docs of PyHeapTypeObject. Maybe add those description info in it.
There was a problem hiding this comment.
I'm not certain what to do with this change. The whole paragraph could be revisited, as Victor hints to. I'm not sure if this change makes things clearer for the reader.
@encukou: thoughts?
There was a problem hiding this comment.
To be technically correct, it's not just types – PyModuleDef is also a PyObject* (though I assume that's for historical reasons only). But that's too much detail here.
| declared. The sole exception are the type objects; they may be static | ||
| :c:type:`PyTypeObject` objects. |
There was a problem hiding this comment.
Would this work?
| declared. The sole exception are the type objects; they may be static | |
| :c:type:`PyTypeObject` objects. | |
| declared. (There are a few exceptions, like static type objects, but even those | |
| are usually manipulated via pointers.) |
iritkatriel left a comment
iritkatriel left a comment There was a problem hiding this comment.
This has merge conflicts now.
bedevere-bot commented Dec 6, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
10 participants
https://bugs.python.org/issue41790