bpo-41944: No longer call eval() on content received via HTTP in the CJK codec tests#22566
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
serhiy-storchaka added tests 
vstinner reviewed Oct 6, 2020
Lib/test/multibytecodec_support.py Outdated
| elifcsetval>=0x100: | ||
| csetch=bytes([(csetval>>8), (csetval&0xff)]) | ||
| else: | ||
| assertdata[0][:2] =='0x' |
Member
There was a problem hiding this comment.
I suggest something like:
if not data[0].startswith('0x'): self.fail(f"Invalid line:{line!r}") vstinner approved these changes Oct 6, 2020
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM.
Tests still pass with this change:
grep -l multibytecodec_support Lib/test/*py > tests ./python -m test -u all --fromfile=tests -j0 -v 
Contributor
miss-islington commented Oct 6, 2020
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2020
…CJK codec tests (pythonGH-22566) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]>
bedevere-bot commented Oct 6, 2020
GH-22576 is a backport of this pull request to the 3.9 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2020
…CJK codec tests (pythonGH-22566) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]>
bedevere-bot commented Oct 6, 2020
GH-22577 is a backport of this pull request to the 3.8 branch. |
miss-islington added a commit that referenced this pull request Oct 6, 2020
…CJK codec tests (GH-22566) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]>
Contributor
miss-islington commented Oct 6, 2020
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Contributor
miss-islington commented Oct 6, 2020
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
bedevere-bot commented Oct 6, 2020
GH-22578 is a backport of this pull request to the 3.7 branch. |
bedevere-bot commented Oct 6, 2020
GH-22579 is a backport of this pull request to the 3.6 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2020
…CJK codec tests (pythonGH-22566) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2020
…CJK codec tests (pythonGH-22566) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner pushed a commit that referenced this pull request Oct 6, 2020
…CJK codec tests (GH-22566) (GH-22577) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
vstinner pushed a commit that referenced this pull request Oct 6, 2020
…UnicodeNames tests (GH-22575) Similarly to GH-22566, those tests called eval() on content received via HTTP in test_named_sequences_full. This likely isn't exploitable because unicodedata.lookup(seqname) is called before self.checkletter(seqname, None) - thus any string which isn't a valid unicode character name wouldn't ever reach the checkletter method. Still, it's probably better to be safe than sorry.
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Oct 9, 2020
* origin/master: (147 commits) Fix the attribute names in the docstring of GenericAlias (pythonGH-22594) bpo-39337: Add a test case for normalizing of codec names (pythonGH-19069) bpo-41557: Update Windows installer to use SQLite 3.33.0 (pythonGH-21960) bpo-41976: Fix the fallback to gcc of ctypes.util.find_library when using gcc>9 (pythonGH-22598) bpo-41306: Allow scale value to not be rounded (pythonGH-21715) bpo-41970: Avoid test failure in test_lib2to3 if the module is already imported (pythonGH-22595) bpo-41376: Fix the documentation of `site.getusersitepackages()` (pythonGH-21602) Revert "bpo-26680: Incorporate is_integer in all built-in and standard library numeric types (pythonGH-6121)" (pythonGH-22584) bpo-41923: PEP 613: Add TypeAlias to typing module (python#22532) Fix comment about PyObject_IsTrue. (pythonGH-22343) bpo-38605: Make 'from __future__ import annotations' the default (pythonGH-20434) bpo-41905: Add abc.update_abstractmethods() (pythonGH-22485) bpo-41944: No longer call eval() on content received via HTTP in the UnicodeNames tests (pythonGH-22575) bpo-41944: No longer call eval() on content received via HTTP in the CJK codec tests (pythonGH-22566) Post 3.10.0a1 Python 3.10.0a1 bpo-41584: clarify when the reflected method of a binary arithemtic operator is called (python#22505) bpo-41939: Fix test_site.test_license_exists_at_url() (python#22559) bpo-41774: Tweak new programming FAQ entry (pythonGH-22562) bpo-41936. Remove macros Py_ALLOW_RECURSION/Py_END_ALLOW_RECURSION (pythonGH-22552) ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
…UnicodeNames tests (pythonGH-22575) Similarly to pythonGH-22566, those tests called eval() on content received via HTTP in test_named_sequences_full. This likely isn't exploitable because unicodedata.lookup(seqname) is called before self.checkletter(seqname, None) - thus any string which isn't a valid unicode character name wouldn't ever reach the checkletter method. Still, it's probably better to be safe than sorry.
ned-deily pushed a commit that referenced this pull request Oct 20, 2020
…CJK codec tests (GH-22566) (GH-22578) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]>
ned-deily pushed a commit that referenced this pull request Oct 20, 2020
…CJK codec tests (GH-22566) (GH-22579) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]>
gentoo-bot pushed a commit to gentoo/cpython that referenced this pull request Dec 14, 2020
…CJK codec tests (pythonGH-22566) (pythonGH-22579) (cherry picked from commit 2ef5caa) Co-authored-by: Serhiy Storchaka <[email protected]> Rebased for Python 2.7 by Michał Górny <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41944