Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions Doc/library/decimal.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -621,13 +621,6 @@ Decimal objects
Return :const:`True` if the argument is either positive or negative
infinity and :const:`False` otherwise.

.. method:: is_integer()

Return :const:`True` if the argument is a finite integral value and
:const:`False` otherwise.

.. versionadded:: 3.10

.. method:: is_nan()

Return :const:`True` if the argument is a (quiet or signaling) NaN and
Expand DownExpand Up@@ -1222,13 +1215,6 @@ In addition to the three supplied contexts, new contexts can be created with the
Returns ``True`` if *x* is infinite; otherwise returns ``False``.


.. method:: is_integer(x)

Returns ``True`` if *x* is finite and integral; otherwise
returns ``False``.

.. versionadded:: 3.10

.. method:: is_nan(x)

Returns ``True`` if *x* is a qNaN or sNaN; otherwise returns ``False``.
Expand Down
26 changes: 7 additions & 19 deletions Doc/library/numbers.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -49,30 +49,19 @@ The numeric tower
numbers.

In short, those are: a conversion to :class:`float`, :func:`math.trunc`,
:func:`round`, :func:`math.floor`, :func:`math.ceil`, :func:`divmod`,
:func:`~Real.is_integer`, ``//``, ``%``, ``<``, ``<=``, ``>``, and ``>=``.
:func:`round`, :func:`math.floor`, :func:`math.ceil`, :func:`divmod`, ``//``,
``%``, ``<``, ``<=``, ``>``, and ``>=``.

Real also provides defaults for :func:`complex`, :attr:`~Complex.real`,
:attr:`~Complex.imag`, and :meth:`~Complex.conjugate`.

.. method:: is_integer()

Returns :const:`True` if this number has a finite and integral value,
otherwise :const:`False`. This is a default implementation which
relies on successful conversion to :class:`int`. It may be overridden
in subclasses (such as it is in :class:`float`) for better performance,
or to handle special values such as NaN which are not
convertible to :class:`int`.

.. versionadded:: 3.10


.. class:: Rational

Subtypes :class:`Real` and adds
:attr:`~Rational.numerator` and :attr:`~Rational.denominator` properties, which
should be in lowest terms. With these, it provides defaults for
:func:`float` and :func:`~Real.is_integer`.
should be in lowest terms. With these, it provides a default for
:func:`float`.

.. attribute:: numerator

Expand All@@ -86,10 +75,9 @@ The numeric tower
.. class:: Integral

Subtypes :class:`Rational` and adds a conversion to :class:`int`. Provides
defaults for :func:`float`, :attr:`~Rational.numerator`,
:attr:`~Rational.denominator`, and :func:`~Real.is_integer`. Adds abstract
methods for ``**`` and bit-string operations: ``<<``, ``>>``, ``&``, ``^``,
``|``, ``~``.
defaults for :func:`float`, :attr:`~Rational.numerator`, and
:attr:`~Rational.denominator`. Adds abstract methods for ``**`` and
bit-string operations: ``<<``, ``>>``, ``&``, ``^``, ``|``, ``~``.


Notes for type implementors
Expand Down
14 changes: 10 additions & 4 deletions Doc/library/stdtypes.rst
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,10 +310,6 @@ the operations, see :ref:`operator-summary`):
+---------------------+---------------------------------+---------+--------------------+
| ``x ** y`` | *x* to the power *y* |\(5) ||
+---------------------+---------------------------------+---------+--------------------+
| ``x.is_integer()`` | ``True`` if *x* has a finite ||:func:`~numbers\ |
|| and integral value, otherwise || .Real.is_integer` |
|| ``False``. |||
+---------------------+---------------------------------+---------+--------------------+

.. index::
triple: operations on; numeric; types
Expand DownExpand Up@@ -587,6 +583,16 @@ class`. float also has the following additional methods.
:exc:`OverflowError` on infinities and a :exc:`ValueError` on
NaNs.

.. method:: float.is_integer()

Return ``True`` if the float instance is finite with integral
value, and ``False`` otherwise::

>>> (-2.0).is_integer()
True
>>> (3.2).is_integer()
False

Two methods support conversion to
and from hexadecimal strings. Since Python's floats are stored
internally as binary numbers, converting a float to or from a
Expand Down
25 changes: 0 additions & 25 deletions Lib/_pydecimal.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -3164,12 +3164,6 @@ def is_zero(self):
"""Return True if self is a zero; otherwise return False."""
returnnotself._is_specialandself._int=='0'

defis_integer(self):
"""Return True is self is finite and integral; otherwise False."""
ifself._is_special:
returnFalse
returnself.to_integral_value(rounding=ROUND_FLOOR) ==self

def_ln_exp_bound(self):
"""Compute a lower bound for the adjusted exponent of self.ln().
In other words, compute r such that self.ln() >= 10**r. Assumes
Expand DownExpand Up@@ -4665,25 +4659,6 @@ def is_zero(self, a):
a=_convert_other(a, raiseit=True)
returna.is_zero()

defis_integer(self, a):
"""Return True if the operand is integral; otherwise return False.
>>> ExtendedContext.is_integer(Decimal('0'))
True
>>> ExtendedContext.is_integer(Decimal('2.50'))
False
>>> ExtendedContext.is_integer(Decimal('-0E+2'))
True
>>> ExtendedContext.is_integer(Decimal('-0.5'))
False
>>> ExtendedContext.is_integer(Decimal('NaN'))
False
>>> ExtendedContext.is_integer(10)
True
"""
a=_convert_other(a, raiseit=True)
returna.is_integer()

defln(self, a):
"""Returns the natural (base e) logarithm of the operand.
Expand Down
21 changes: 1 addition & 20 deletions Lib/numbers.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -148,7 +148,7 @@ class Real(Complex):
"""To Complex, Real adds the operations that work on real numbers.
In short, those are: a conversion to float, trunc(), divmod,
is_integer, %, <, <=, >, and >=.
%, <, <=, >, and >=.
Real also provides defaults for the derived operations.
"""
Expand DownExpand Up@@ -242,17 +242,6 @@ def __le__(self, other):
"""self <= other"""
raiseNotImplementedError

defis_integer(self):
"""Return True if the Real is integral; otherwise return False.
This default implementation can be overridden in subclasses
for performance reasons or to deal with values such as NaN,
which would otherwise cause an exception to be raised.
"""
# Although __int__ is not defined at this level, the int
# constructor falls back to __trunc__, which we do have.
returnself==int(self)

# Concrete implementations of Complex abstract methods.
def__complex__(self):
"""complex(self) == complex(float(self), 0)"""
Expand DownExpand Up@@ -301,10 +290,6 @@ def __float__(self):
"""
returnself.numerator/self.denominator

defis_integer(self):
"""Return True if the Rational is integral; otherwise return False."""
returnself.denominator==1


classIntegral(Rational):
"""Integral adds a conversion to int and the bit-string operations."""
Expand DownExpand Up@@ -401,8 +386,4 @@ def denominator(self):
"""Integers have a denominator of 1."""
return1

defis_integer(self):
"""Return True; all Integrals represent an integral value."""
returnTrue

Integral.register(int)
18 changes: 0 additions & 18 deletions Lib/test/decimaltestdata/extra.decTest
Original file line numberDiff line numberDiff line change
Expand Up@@ -2346,24 +2346,6 @@ bool2096 iszero sNaN -> 0
bool2097 iszero -sNaN -> 0
bool2098 iszero sNaN123 -> 0
bool2099 iszero -sNaN123 -> 0
bool2100 is_integer -1.0 -> 1
bool2101 is_integer 0.0 -> 1
bool2102 is_integer 1.0 -> 1
bool2103 is_integer 42 -> 1
bool2104 is_integer 1e2 -> 1
bool2105 is_integer 1.5 -> 0
bool2106 is_integer 1e-2 -> 0
bool2107 is_integer NaN -> 0
bool2109 is_integer -NaN -> 0
bool2110 is_integer NaN123 -> 0
bool2111 is_integer -NaN123 -> 0
bool2112 is_integer sNaN -> 0
bool2113 is_integer -sNaN -> 0
bool2114 is_integer sNaN123 -> 0
bool2115 is_integer -sNaN123 -> 0
bool2116 is_integer Infinity -> 0
bool2117 is_integer -Infinity -> 0


------------------------------------------------------------------------
-- The following tests (pwmx0 through pwmx440) are for the --
Expand Down
5 changes: 0 additions & 5 deletions Lib/test/test_bool.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -354,11 +354,6 @@ def test_real_and_imag(self):
self.assertIs(type(False.real), int)
self.assertIs(type(False.imag), int)

deftest_always_is_integer(self):
# Issue #26680: Incorporating number.is_integer into bool
self.assertTrue(all(b.is_integer() forbin (False, True)))


deftest_main():
support.run_unittest(BoolTest)

Expand Down
24 changes: 0 additions & 24 deletions Lib/test/test_decimal.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,6 @@ def setUp(self):
'is_snan',
'is_subnormal',
'is_zero',
'is_integer',
'same_quantum')

defread_unlimited(self, v, context):
Expand DownExpand Up@@ -2727,7 +2726,6 @@ def test_named_parameters(self):
self.assertRaises(TypeError, D(1).is_snan, context=xc)
self.assertRaises(TypeError, D(1).is_signed, context=xc)
self.assertRaises(TypeError, D(1).is_zero, context=xc)
self.assertRaises(TypeError, D(1).is_integer, context=xc)

self.assertFalse(D("0.01").is_normal(context=xc))
self.assertTrue(D("0.01").is_subnormal(context=xc))
Expand DownExpand Up@@ -3199,15 +3197,6 @@ def test_is_zero(self):
self.assertEqual(c.is_zero(10), d)
self.assertRaises(TypeError, c.is_zero, '10')

deftest_is_integer(self):
Decimal=self.decimal.Decimal
Context=self.decimal.Context

c=Context()
b=c.is_integer(Decimal(10))
self.assertEqual(c.is_integer(10), b)
self.assertRaises(TypeError, c.is_integer, '10')

deftest_ln(self):
Decimal=self.decimal.Decimal
Context=self.decimal.Context
Expand DownExpand Up@@ -4371,19 +4360,6 @@ def test_implicit_context(self):
self.assertTrue(Decimal("-1").is_signed())
self.assertTrue(Decimal("0").is_zero())
self.assertTrue(Decimal("0").is_zero())
self.assertTrue(Decimal("-1").is_integer())
self.assertTrue(Decimal("0").is_integer())
self.assertTrue(Decimal("1").is_integer())
self.assertTrue(Decimal("42").is_integer())
self.assertTrue(Decimal("1e2").is_integer())
self.assertFalse(Decimal("1.5").is_integer())
self.assertFalse(Decimal("1e-2").is_integer())
self.assertFalse(Decimal("NaN").is_integer())
self.assertFalse(Decimal("-NaN").is_integer())
self.assertFalse(Decimal("sNaN").is_integer())
self.assertFalse(Decimal("-sNaN").is_integer())
self.assertFalse(Decimal("Inf").is_integer())
self.assertFalse(Decimal("-Inf").is_integer())

# Copy
withlocalcontext() asc:
Expand Down
11 changes: 0 additions & 11 deletions Lib/test/test_fractions.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -724,17 +724,6 @@ def denominator(self):
self.assertEqual(type(f.numerator), myint)
self.assertEqual(type(f.denominator), myint)

deftest_is_integer(self):
# Issue #26680: Incorporating number.is_integer into Fraction
self.assertTrue(F(-1, 1).is_integer())
self.assertTrue(F(0, 1).is_integer())
self.assertTrue(F(1, 1).is_integer())
self.assertTrue(F(42, 1).is_integer())
self.assertTrue(F(2, 2).is_integer())
self.assertTrue(F(8, 4).is_integer())
self.assertFalse(F(1, 2).is_integer())
self.assertFalse(F(1, 3).is_integer())
self.assertFalse(F(2, 3).is_integer())

if__name__=='__main__':
unittest.main()
4 changes: 0 additions & 4 deletions Lib/test/test_long.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1381,10 +1381,6 @@ class myint(int):
self.assertEqual(type(numerator), int)
self.assertEqual(type(denominator), int)

deftest_int_always_is_integer(self):
# Issue #26680: Incorporating number.is_integer into int
self.assertTrue(all(x.is_integer() forxin (-1, 0, 1, 42)))


if__name__=="__main__":
unittest.main()
31 changes: 0 additions & 31 deletions Lib/test/test_numeric_tower.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,6 @@
importsys
importoperator

fromnumbersimportReal, Rational, Integral
fromdecimalimportDecimalasD
fromfractionsimportFractionasF

Expand DownExpand Up@@ -199,35 +198,5 @@ def test_complex(self):
self.assertRaises(TypeError, op, v, z)


classIsIntegerTest(unittest.TestCase):

deftest_real_is_integer(self):
self.assertTrue(Real.is_integer(-1.0))
self.assertTrue(Real.is_integer(0.0))
self.assertTrue(Real.is_integer(1.0))
self.assertTrue(Real.is_integer(42.0))

self.assertFalse(Real.is_integer(-0.5))
self.assertFalse(Real.is_integer(4.2))

deftest_rational_is_integer(self):
self.assertTrue(Rational.is_integer(F(-1, 1)))
self.assertTrue(Rational.is_integer(F(0, 1)))
self.assertTrue(Rational.is_integer(F(1, 1)))
self.assertTrue(Rational.is_integer(F(42, 1)))
self.assertTrue(Rational.is_integer(F(2, 2)))
self.assertTrue(Rational.is_integer(F(8, 4)))

self.assertFalse(Rational.is_integer(F(1, 2)))
self.assertFalse(Rational.is_integer(F(1, 3)))
self.assertFalse(Rational.is_integer(F(2, 3)))

deftest_integral_is_integer(self):
self.assertTrue(Integral.is_integer(-1))
self.assertTrue(Integral.is_integer(0))
self.assertTrue(Integral.is_integer(1))
self.assertTrue(Integral.is_integer(1729))


if__name__=='__main__':
unittest.main()
1 change: 0 additions & 1 deletion Misc/ACKS
Original file line numberDiff line numberDiff line change
Expand Up@@ -1612,7 +1612,6 @@ Roman Skurikhin
Ville Skyttä
Michael Sloan
Nick Sloan
Robert Smallshire
Václav Šmilauer
Allen W. Smith
Christopher Smith
Expand Down
6 changes: 2 additions & 4 deletions Modules/_decimal/_decimal.c
Original file line numberDiff line numberDiff line change
Expand Up@@ -4138,7 +4138,6 @@ Dec_BoolFunc(mpd_isqnan)
Dec_BoolFunc(mpd_issnan)
Dec_BoolFunc(mpd_issigned)
Dec_BoolFunc(mpd_iszero)
Dec_BoolFunc(mpd_isinteger)

/* Boolean functions, optional context arg */
Dec_BoolFuncVA(mpd_isnormal)
Expand DownExpand Up@@ -4773,7 +4772,6 @@ static PyMethodDef dec_methods [] =
{"is_snan", dec_mpd_issnan, METH_NOARGS, doc_is_snan },
{"is_signed", dec_mpd_issigned, METH_NOARGS, doc_is_signed },
{"is_zero", dec_mpd_iszero, METH_NOARGS, doc_is_zero },
{"is_integer", dec_mpd_isinteger, METH_NOARGS, doc_is_integer},

/* Boolean functions, optional context arg */
{"is_normal", (PyCFunction)(void(*)(void))dec_mpd_isnormal, METH_VARARGS|METH_KEYWORDS, doc_is_normal },
Expand DownExpand Up@@ -5185,7 +5183,6 @@ DecCtx_BoolFunc_NO_CTX(mpd_isqnan)
DecCtx_BoolFunc_NO_CTX(mpd_issigned)
DecCtx_BoolFunc_NO_CTX(mpd_issnan)
DecCtx_BoolFunc_NO_CTX(mpd_iszero)
DecCtx_BoolFunc_NO_CTX(mpd_isinteger)

staticPyObject*
ctx_iscanonical(PyObject*contextUNUSED, PyObject*v)
Expand DownExpand Up@@ -5467,7 +5464,6 @@ static PyMethodDef context_methods [] =
{"is_snan", ctx_mpd_issnan, METH_O, doc_ctx_is_snan },
{"is_subnormal", ctx_mpd_issubnormal, METH_O, doc_ctx_is_subnormal },
{"is_zero", ctx_mpd_iszero, METH_O, doc_ctx_is_zero },
{"is_integer", ctx_mpd_isinteger, METH_O, doc_ctx_is_integer },

/* Functions with a single decimal argument */
{"_apply", PyDecContext_Apply, METH_O, NULL }, /* alias for apply */
Expand DownExpand Up@@ -6101,3 +6097,5 @@ PyInit__decimal(void)

returnNULL; /* GCOV_NOT_REACHED */
}


Loading