bpo-42222: Modernize integer test/conversion in randrange()

[rhettinger]

Moves the int(x) == x test and conversion into the C code for operator.index().

Provides a 7% speed up:

$ pytime -s 'from random import randrange' 'randrange(15)' # baseline 500000 loops, best of 11: 540 nsec per loop $ pytime -s 'from random import randrange' 'randrange(15)' # new versio 500000 loops, best of 11: 502 nsec per loop 

It should become even faster when we get a zero-cost try.

It's odd that non-integers raise a ValueError. I think that should have been TypeError.

https://bugs.python.org/issue42222

[serhiy-storchaka]

Currently you are on the way to #19112 (which already has tests and documentation and cover corner cases).

[github-actions]

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

[serhiy-storchaka]

What about #19112?

[rhettinger]

I merged in the relevant parts of #19112. The principal differences are:

• The TypeError won't start being emitted until the after the deprecation period.
• Improved wording for the doc entries.
• Tests focus solely on the deprecations.
• All existing behavior remains intact until after the deprecation.

[serhiy-storchaka]

• The TypeError won't start being emitted until the after the deprecation period.

As in #19112 initially. I changed ValueError to TypeError on your request.

• Improved wording for the doc entries.

I would appreciate any suggestions to change wording.

• Tests focus solely on the deprecations.

Yes, tests in #19112 cover more cases.

• All existing behavior remains intact until after the deprecation.

As well as in #19112.

But this PR still has issues. It does not emit warning for randrange(10, 20, 1.0).

[bedevere-bot]

@rhettinger: Please replace # with GH- in the commit message next time. Thanks!