Skip to content

gh-103092: Prep curses module for multi-phase init#23091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
koubaa wants to merge 3 commits into from
Closed

gh-103092: Prep curses module for multi-phase init #23091

koubaa wants to merge 3 commits into from

Conversation

@koubaa
Copy link
Contributor

@koubaakoubaa commented Nov 2, 2020•
edited by bedevere-app bot
Loading

shihai1991
shihai1991 reviewed Nov 2, 2020
View reviewed changes
shihai1991
shihai1991 reviewed Nov 2, 2020
View reviewed changes
shihai1991
shihai1991 reviewed Nov 2, 2020
View reviewed changes
@shihai1991
Copy link
Member

shihai1991 commented Nov 2, 2020

cc @vstinner@corona10

@koubaakoubaa marked this pull request as draft November 3, 2020 00:31
@koubaakoubaa marked this pull request as ready for review November 4, 2020 02:37
@koubaa
Copy link
ContributorAuthor

koubaa commented Nov 4, 2020

@vstinner@corona10@shihai1991 please review

vstinner
vstinner reviewed Nov 4, 2020
View reviewed changes
@github-actions
Copy link

github-actionsbot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actionsgithub-actionsbot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@koubaakoubaaforce-pushed the bpo-1635741-curses-prep branch from c96930b to 0dc705bCompareFebruary 28, 2021 18:31
@koubaa
Copy link
ContributorAuthor

koubaa commented Feb 28, 2021

@vstinner would you please review?

vstinner
vstinner reviewed Mar 11, 2021
View reviewed changes
Modules/_cursesmodule.c
} \
if (PyDict_SetItemString(d, string, o) < 0){\
Py_DECREF(o); \
goto error; \
Copy link
Member

@vstinnervstinnerMar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"return NULL;" is enough: you should remove the error label. An error label is used when you need to clean up things, it's not the case here. Same remark at the bottom of the file.

Modules/_cursesmodule.c
return NULL;
}

static void *PyCurses_API[PyCurses_API_pointers];
Copy link
Member

@vstinnervstinnerMar 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are warnings on the PR, like ‘PyCurses_API’ defined but not used [-Wunused-variable].

@iritkatriel
Copy link
Member

iritkatriel commented Apr 11, 2022

https://bugs.python.org/issue1635741 is closed. What is the status of this PR?

@vstinner
Copy link
Member

vstinner commented Apr 19, 2022

The change is still relevant, but should use a new issue number.

Moreover, the SC asked to put the conversion of static types to heap types on hold. @encukou and @erlend-aasland wrote https://peps.python.org/pep-0687/ which may unblock the situation but it's still a draft.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jun 27, 2022

FYI, PEP-687 was just accepted.

@github-actionsgithub-actionsbot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
@kylotankylotanmannequin mentioned this pull request Sep 19, 2022
Closed
@encukouencukou changed the title bpo-1635741: Prep curses module for multi-phase initgh-103092: Prep curses module for multi-phase initMar 28, 2024
@bedevere-appbedevere-appbot mentioned this pull request Mar 28, 2024
Closed
25 tasks
@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 8, 2024

Closing as per #101714 (comment). Thanks for the effort, Mohamed!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner left review comments

@shihai1991shihai1991shihai1991 left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@koubaa@shihai1991@iritkatriel@vstinner@erlend-aasland@the-knights-who-say-ni@ezio-melotti@bedevere-bot