bpo-42243: Use PyModule_Add*() in _sre iso. direct module dict manipulation

[erlend-aasland]

https://bugs.python.org/issue42243

[serhiy-storchaka]

Just for the case, add tests that MAXREPEAT and MAXGROUPS > 0.

[erlend-aasland]

Just for the case, add tests that MAXREPEAT and MAXGROUPS > 0.

Would a simple assert() be sufficient, or did you mean adding a unit test?

[serhiy-storchaka]

Would a simple assert() be sufficient, or did you mean adding a unit test?

I meant adding a test in Lib/test/test_re.py. If somebody will break this code in future it will get clearer test failure.

[erlend-aasland]

Would a simple assert() be sufficient, or did you mean adding a unit test?

I meant adding a test in Lib/test/test_re.py. If somebody will break this code in future it will get clearer test failure.

Got it. Signedness test added in 8561628.

[erlend-aasland]

@serhiy-storchaka are you ok with this PR as it stands?

[erlend-aasland]

Closing, as this was incorporated in #23393