bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP)#23142

frenzymadness · 2020-11-04T11:28:46Z

This change:

merges distutils.sysconfig into sysconfig while keeping the original functionality and
marks distutils.sysconfig as deprecated

Commits basically describe my progress step by step. Some discussions already happened in my private PR.

PEP 632 is still a draft so I'm opening this PR the same. PEP proposal and discussion.

https://bugs.python.org/issue41282

Lib/sysconfig.py

github-actions · 2020-12-16T00:27:32Z

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

frenzymadness · 2020-12-16T07:43:31Z

This PR is waiting for a final decision about the PEP.

github-actions · 2021-01-16T01:01:41Z

This PR is stale because it has been open for 30 days with no activity.

pradyunsg · 2021-01-23T10:15:51Z

The PEP is accepted now.

Doc/distutils/apiref.rst

frenzymadness · 2021-02-09T12:37:56Z

The pep is accepted so this PR is no longer a draft. Also, a note about the deprecation already exists here so I think it's enough to mention it once.

encukou · 2021-02-12T19:56:28Z

Can you add a NEWS entry?
(The blurb tool is packaged in Fedora, FWIW.)

frenzymadness · 2021-02-15T11:55:24Z

News entry added.

zooba · 2021-02-15T19:38:16Z

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!

frenzymadness · 2021-02-28T11:19:31Z

I have no other comments, so unless someone else spots something I'll get this merged before the next alpha release. Thanks, @frenzymadness!

Thank you! AFAIK the next alpha should be released tomorrow. Will we include this in it?

…fig to sysconfig

…edtogether with the module.

…ly when needed

and deprecated them.

frenzymadness · 2021-04-16T08:49:08Z

I've rebased the commits and fixed a conflict. The failing test is not related to this change.

Could you please merge this?

frenzymadness · 2021-04-16T14:07:48Z

@encukou see the last commit and PTAL.

pradyunsg · 2021-04-16T14:42:31Z

And... Could someone also relabel this, to remove the "DO-NOT-MERGE" label here? :)

Doc/distutils/apiref.rst

Co-authored-by: Éric Araujo <[email protected]>

frenzymadness · 2021-04-22T05:00:38Z

@zooba could you please take a look at this PR? The time of the first beta release is approaching.

encukou · 2021-04-23T12:01:43Z

The patch looks good to me, it was seen by many people and I see no objections. I'll merge and watch the buildbots.

hroncok · 2021-06-08T19:01:08Z

I think there is a regression in distutils.sysconfig.parse_makefile() caused by this change.

https://bugs.python.org/issue44351

frenzymadness requested review from lysnikolaou and pablogsal as code owners November 4, 2020 11:28

the-knights-who-say-ni added the CLA signed label Nov 4, 2020

bedevere-bot added the awaiting review label Nov 4, 2020

frenzymadness mentioned this pull request Nov 4, 2020
Sysconfig merge frenzymadness/cpython#2
Closed

frenzymadness marked this pull request as draft November 4, 2020 11:31

merwok added the DO-NOT-MERGE label Nov 4, 2020

merwok reviewed Nov 4, 2020
View reviewed changes

Lib/sysconfig.py Outdated Show resolvedHide resolved

merwok reviewed Nov 4, 2020
View reviewed changes

Lib/sysconfig.py Outdated Show resolvedHide resolved

zooba self-assigned this Nov 4, 2020

frenzymadness force-pushed the distutils_sysconfig branch from 70fe4be to 7d6d0bbCompare November 13, 2020 11:47

github-actionsbot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020

merwok removed the stale Stale PR or inactive for long period of time. label Dec 16, 2020

github-actionsbot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021

merwok removed awaiting review stale Stale PR or inactive for long period of time. labels Jan 16, 2021

merwok reviewed Jan 23, 2021
View reviewed changes

Doc/distutils/apiref.rst Outdated Show resolvedHide resolved

frenzymadness force-pushed the distutils_sysconfig branch from 7d6d0bb to 51c232cCompare February 9, 2021 12:06

frenzymadness changed the title ~~PEP 632: Deprecate distutils.sysconfig (partial implementation of the PEP)~~bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP)Feb 9, 2021

frenzymadness marked this pull request as ready for review February 9, 2021 12:38

Mark distutils.sysconfig as deprecated
9de38bb

Rename distutils_compat to keep_unresolved and reverse the logic
318428d

frenzymadness force-pushed the distutils_sysconfig branch from 8d73015 to cf2bb35Compare April 16, 2021 07:01

frenzymadness added 10 commits April 16, 2021 09:22

Merge all import from sysconfig to one statement
6136978

Allow import of sysconfig when re module is not available
e635dbd

Add a TODO comment about PEP 632
d8a8cf0

Mark distutils.sysconfig as deprecated in docs
e317db5

Copy docs for get_python_inc and get_python_lib from distutils.syscon…
17206f0
…fig to sysconfig

Move customize_compiler back to distutils.sysconfig as it'll be remov…
04ef7af
…edtogether with the module.

Fix import of not-yet-initialized _CONFIG_VARS
6015255

Switch global vars from regex objects to raw strings and import re on…
abc310b
…ly when needed

Move get_python_lib and get_python_inc back to distutils.sysconfig
17aa9c4
and deprecated them.

News entry
be181b6

frenzymadness force-pushed the distutils_sysconfig branch from cf2bb35 to be181b6Compare April 16, 2021 07:27

Restore build_flags accidentally removed during a rebase
e253a3d

encukou removed the DO-NOT-MERGE label Apr 16, 2021

merwok reviewed Apr 16, 2021
View reviewed changes

Doc/distutils/apiref.rst Outdated Show resolvedHide resolved

Update Doc/distutils/apiref.rst
cd8e387
Co-authored-by: Éric Araujo <[email protected]>

encukou merged commit 90d02e5 into python:masterApr 23, 2021

frenzymadness deleted the distutils_sysconfig branch April 26, 2021 08:00

frenzymadness mentioned this pull request Jun 10, 2021
bpo-44351: Restore back parse_makefile in distutils.sysconfig #26637
Merged

This was referenced Dec 21, 2021
bpo-41282: Load install schemes from sysconfig (port from CPython) pypa/distutils#84
Closed
[BUG] No module named '_sysconfigdata_d_linux_x86_64-linux-gnu' pypa/setuptools#2946
Closed

jaraco mentioned this pull request May 9, 2022
Deprecate and remove distutils #85454
Closed

jkloth mentioned this pull request May 18, 2022
gh-92897: Ensure venv --copies respects source build property of the creating interpreter (GH-92899) #92899
Merged

Uh oh!

bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP)#23142

bpo-41282: (PEP 632) Deprecate distutils.sysconfig (partial implementation of the PEP) #23142

Uh oh!

Conversation

frenzymadness commented Nov 4, 2020• edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsbot commented Dec 16, 2020

Uh oh!

frenzymadness commented Dec 16, 2020

Uh oh!

github-actionsbot commented Jan 16, 2021

Uh oh!

pradyunsg commented Jan 23, 2021

Uh oh!

Uh oh!

frenzymadness commented Feb 9, 2021

Uh oh!

encukou commented Feb 12, 2021

Uh oh!

frenzymadness commented Feb 15, 2021

Uh oh!

zooba commented Feb 15, 2021

Uh oh!

frenzymadness commented Feb 28, 2021

Uh oh!

frenzymadness commented Apr 16, 2021

Uh oh!

frenzymadness commented Apr 16, 2021

Uh oh!

pradyunsg commented Apr 16, 2021

Uh oh!

Uh oh!

frenzymadness commented Apr 22, 2021

Uh oh!

encukou commented Apr 23, 2021

Uh oh!

hroncok commented Jun 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

frenzymadness commented Nov 4, 2020•
edited by bedevere-bot
Loading