bpo-42264: Deprecate sqlite3.OptimizedUnicode#23163

erlend-aasland · 2020-11-05T12:30:49Z

Lib/sqlite3/deprecated.py

bedevere-bot · 2020-11-05T12:46:18Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

erlend-aasland · 2020-11-05T13:39:21Z

I have made the requested changes; please review again

bedevere-bot · 2020-11-05T13:39:24Z

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka

LGTM.

erlend-aasland · 2020-11-05T13:52:59Z

Thanks for reviewing, @serhiy-storchaka!

serhiy-storchaka · 2020-11-05T13:53:45Z

And it could be good idea to add tests for filename to all existing deprecation tests.

erlend-aasland · 2020-11-05T13:55:20Z

And it could be good idea to add tests for filename to all existing deprecation tests.

I agree. I can open an issue for it.

erlend-aasland · 2020-11-05T17:17:23Z

And it could be good idea to add tests for filename to all existing deprecation tests.

There's a lot:

bash$ grep -r "DeprecationWarning" Lib/test | grep -v " as " | wc -l (master)cpython.git 519

Lib/sqlite3/deprecated.py

Misc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst

Doc/whatsnew/3.10.rst

Co-authored-by: Victor Stinner <vstinner@python.org>

erlend-aasland · 2020-11-05T19:57:05Z

PTAL, @vstinner

Lib/sqlite3/__init__.py

erlend-aasland · 2020-11-05T23:14:57Z

FYI, Ubuntu CI hangs again:
test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

vstinner · 2020-11-06T16:01:17Z

test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)!

It is a know issue https://bugs.python.org/issue42142

You can ignore it. When it happens, I simply re-run the job until it pass.

vstinner

Good, it's way better! More comments.

Misc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst

Lib/sqlite3/__init__.py

Use the same text as the What's New entry.

Co-authored-by: Victor Stinner <vstinner@python.org>

erlend-aasland · 2020-11-06T19:12:55Z

Please take another look, @vstinner.

vstinner

LGTM.

@serhiy-storchaka: Do you want to double check this PR?

erlend-aasland · 2020-11-17T14:29:17Z

@serhiy-storchaka Will you merge this after double checking, or will that be up to another core dev to decide?

The following sqlite3 features were deprecated in 3.10, scheduled for removal in 3.12: - sqlite3.OptimizedUnicode (pythongh-23163) - sqlite3.enable_shared_cache (pythongh-24008) Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

The following sqlite3 features were deprecated in 3.10, scheduled for removal in 3.12: - sqlite3.OptimizedUnicode (gh-23163) - sqlite3.enable_shared_cache (gh-24008) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Deprecate OptimizedUnicode
af2c7e5

erlend-aasland requested a review from berkerpeksag as a code owner November 5, 2020 12:30

the-knights-who-say-ni added the CLA signed label Nov 5, 2020

bedevere-bot added the awaiting review label Nov 5, 2020

erlend-aasland changed the title ~~bpo-42264: Deprecate OptimizedUnicode~~bpo-42264: Deprecate sqlite3.OptimizedUnicodeNov 5, 2020

Erlend E. Aasland added 2 commits November 5, 2020 13:39

Add NEWS and update "What's new"
f8dfb6d

Restore type checks in unit test
f25e85a

serhiy-storchaka approved these changes Nov 5, 2020
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Nov 5, 2020

serhiy-storchaka requested changes Nov 5, 2020
View reviewed changes

Lib/sqlite3/deprecated.py Outdated Show resolvedHide resolved

bedevere-bot added awaiting changes and removed awaiting merge labels Nov 5, 2020

Address review comment: Refer to caller when warning, and verify this
a9e959f

bedevere-bot added awaiting change review and removed awaiting changes labels Nov 5, 2020

bedevere-bot requested a review from serhiy-storchaka November 5, 2020 13:39

serhiy-storchaka approved these changes Nov 5, 2020
View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Nov 5, 2020

vstinner reviewed Nov 5, 2020
View reviewed changes

Lib/sqlite3/deprecated.py Outdated Show resolvedHide resolved
Misc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst Outdated Show resolvedHide resolved
Doc/whatsnew/3.10.rst Outdated Show resolvedHide resolved

Erlend Egeberg Aaslandand others added 2 commits November 5, 2020 20:11

Address review: Improve NEWS text
3cd247f
Co-authored-by: Victor Stinner <vstinner@python.org>

Address review: improve "What's new"
b106c9e

Address review: Move deprecation warning to __init__.py
b364cf5

Restore dbapi2 import in __init__.py
3320b42

erlend-aasland commented Nov 5, 2020
View reviewed changes

Lib/sqlite3/__init__.py Outdated Show resolvedHide resolved

Improve warning wording
62d2e9b

vstinner reviewed Nov 6, 2020
View reviewed changes

Misc/NEWS.d/next/Library/2020-11-05-13-32-41.bpo-42264.r4KYUU.rst Outdated Show resolvedHide resolved
Lib/sqlite3/__init__.py Outdated Show resolvedHide resolved

Erlend E. Aaslandand others added 2 commits November 6, 2020 20:08

Address review comment: Improve NEWS entry
2507fd0
Use the same text as the What's New entry.

Address review comment: Add bpo reference to __init__.py
fe7c65e
Co-authored-by: Victor Stinner <vstinner@python.org>

vstinner approved these changes Nov 12, 2020
View reviewed changes

serhiy-storchaka approved these changes Nov 17, 2020
View reviewed changes

serhiy-storchaka merged commit a1f401a into python:masterNov 17, 2020

bedevere-bot removed the awaiting merge label Nov 17, 2020

erlend-aasland deleted the bpo-42264 branch November 17, 2020 19:55

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
bpo-42264: Deprecate sqlite3.OptimizedUnicode (pythonGH-23163)
36a56d2

This was referenced May 9, 2022
sqlite3: remove features deprecated in 3.10 #92547
Closed
gh-92547: Remove deprecated sqlite3 features #92548
Merged

hafizulsaat92 approved these changes Jul 4, 2025
View reviewed changes

Uh oh!

bpo-42264: Deprecate sqlite3.OptimizedUnicode#23163

bpo-42264: Deprecate sqlite3.OptimizedUnicode #23163

Uh oh!

Conversation

erlend-aasland commented Nov 5, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Nov 5, 2020

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

bedevere-bot commented Nov 5, 2020

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

serhiy-storchaka commented Nov 5, 2020

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

Uh oh!

erlend-aasland commented Nov 5, 2020

Uh oh!

vstinner commented Nov 6, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Nov 6, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Nov 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented Nov 5, 2020•
edited
Loading