bpo-1635741: Port _random to the multi-phase init#23381
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Port the _random extension module to the multi-phase initialization API (PEP 489). * Create Random_Type using PyType_FromModuleAndSpec(). * Add get_random_state_from_type() function. It replaces the removed _randomstate_global macro.
MemberAuthor
vstinner commented Nov 18, 2020
@corona10@shihai1991: Would you mind to review my PR? Especially the new get_random_state_from_type() function. |
Member
tiran commented Nov 18, 2020
This PR is a duplicate of #23359 |
MemberAuthor
vstinner commented Nov 19, 2020
Oh, I missed your PR. I abandon mine and approved yours. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the _random extension module to the multi-phase initialization
API (PEP 489).
_randomstate_global macro.
https://bugs.python.org/issue1635741